archangel/installer/lib/common.sh, branch mainArch Linux installer ISO — ZFS-on-root or BTRFS, doubles as rescue disk
https://git.cjennings.net/archangel/atom?h=main2026-04-13T04:10:17+00:00refactor: merge install_base and install_base_btrfs2026-04-13T04:10:17+00:00Craig Jenningsc@cjennings.net2026-04-13T04:10:17+00:00urn:sha1:bc613e72238f864a597777826d1f9cc533c4cffa
Extract the pacstrap package list into pacstrap_packages(filesystem)
in lib/common.sh (common + filesystem-specific). install_base() now
dispatches on FILESYSTEM for both the archzfs-repo-append and the
package list. install_base_btrfs() deleted; install_btrfs() call site
updated to invoke install_base.
Old: 49 + 38 lines of ~95% copy-paste.
New: 32 lines + a 20-line pure helper.
7 bats tests cover: zfs has zfs-dkms/zfs-utils, btrfs has btrfs-progs
+ grub + grub-btrfs + snapper + snap-pac, each flavor excludes the
other's specifics, common packages are in both, unknown filesystem
returns status 1, output is one-per-line. make test: 65/65.
refactor: unify get_{luks,zfs}_passphrase and get_root_password2026-04-13T04:07:46+00:00Craig Jenningsc@cjennings.net2026-04-13T04:07:46+00:00urn:sha1:9f6c75916cee8cb65b21b71c69f62d080818ad63
Extract the prompt/confirm/min-length loop into prompt_password() in
lib/common.sh using a nameref for the output variable, so UI output
stays on the terminal (no command-substitution capture) and the three
callers collapse from ~30 lines each to a single helper call.
- get_luks_passphrase() — min 8 chars
- get_zfs_passphrase() — min 8 chars
- get_root_password() — no min (was unchecked before; preserved)
5 bats tests added: match+min-ok path, length-retry loop,
mismatch-retry loop, min_len=0 disables check, empty passphrase
when min_len=0. make test: 58/58.
feat: default to no-color output, add --color flag to enable2026-04-10T03:02:52+00:00Craig Jenningsc@cjennings.net2026-04-10T03:02:52+00:00urn:sha1:778a9150cdcd15216e0c1c6d7e1e3843cf455546
Keeps logs and SSH output clean. Use archangel --color for colored output.
refactor: rename custom/ to installer/ for clarity2026-02-23T17:54:25+00:00Craig Jenningsc@cjennings.net2026-02-23T17:54:25+00:00urn:sha1:fd2ea796b20bcbebea19c43978fb08e3cd6754ed
The custom/ directory name was an archiso implementation detail. Renamed
to installer/ which clearly communicates that this directory contains the
installer scripts and utilities that ship on the ISO.
Updated all references in build.sh, Makefile, test-install.sh, and README.