From c74f656694e084fdf748f7ac86aa4b2361cbe1ed Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Fri, 23 Jan 2026 18:02:52 -0600
Subject: Fix set -e compatibility in lib functions

- Replace [[ ]] && error pattern with if/then/fi
- Pattern causes exit when condition is false with set -e
- Fixed in: common.sh, config.sh, disk.sh, install-archzfs

Discovered during VM testing: the && short-circuit returns exit
code 1 when condition is false, triggering set -e to abort.
---
 custom/lib/config.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'custom/lib/config.sh')

diff --git a/custom/lib/config.sh b/custom/lib/config.sh
index 82f5d77..cec3d8c 100644
--- a/custom/lib/config.sh
+++ b/custom/lib/config.sh
@@ -122,6 +122,8 @@ validate_config() {
         ((errors++))
     fi
 
-    [[ $errors -gt 0 ]] && error "Config validation failed with $errors error(s)"
+    if [[ $errors -gt 0 ]]; then
+        error "Config validation failed with $errors error(s)"
+    fi
     info "Config validation passed"
 }
-- 
cgit v1.2.3