From dc7a2b554af8bd78387c457c28787149a0ebbc56 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Fri, 23 Jan 2026 12:36:13 -0600
Subject: Add code review workflow and project cleanup tasks

- Create docs/project-workflows/code-review.org with comprehensive
  code review checklist based on Code Review Pyramid framework
- Add 14 new tasks to todo.org from senior developer code review:
  - Priority A: README GRUB refs, missing LICENSE, skeleton script
  - Priority B: Stale files, Makefile lint, documentation gaps
  - Priority C: Style consistency, .editorconfig, test docs
- Add Makefile targets to todo.org: deps, lint, deploy
- Create docs/session-context.org for session tracking
---
 docs/session-context.org | 51 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 docs/session-context.org

(limited to 'docs/session-context.org')

diff --git a/docs/session-context.org b/docs/session-context.org
new file mode 100644
index 0000000..580be99
--- /dev/null
+++ b/docs/session-context.org
@@ -0,0 +1,51 @@
+#+TITLE: Session Context - Active Session
+#+DATE: 2026-01-23
+
+* Current Session: Friday 2026-01-23 @ 11:28 CST
+
+** Current Task
+Code review of archzfs project complete. Issues documented in todo.org.
+
+** Completed This Session
+- Merged zfsbootmenu branch to main (fast-forward, pushed to origin)
+- ratio booted successfully with ZFSBootMenu
+- Researched code review best practices (10+ web searches)
+- Created docs/project-workflows/code-review.org
+  - Core Checklist: ~27 items across pyramid levels
+  - Deep Dives: Security, Performance, Concurrency, Error Handling, API Compatibility, Dependencies
+- Conducted senior developer code review of entire archzfs codebase
+- Added 14 new tasks to todo.org based on code review findings
+
+** Code Review Findings Summary
+*** Critical (Priority A)
+- README.org has outdated GRUB references (now uses ZFSBootMenu)
+- Missing LICENSE file (referenced but doesn't exist)
+- custom/archsetup-zfs is a non-functional skeleton
+- Initial password should be configurable, not hardcoded
+
+*** Important (Priority B)
+- Stale SESSION-CONTEXT.md should be deleted
+- PLAN-zfsbootmenu-implementation.org should move to docs/
+- Makefile lint target swallows errors
+- Unclear directories need documentation or gitignore
+- Empty docs/someday-maybe.org
+
+*** Cleanup (Priority C)
+- Inconsistent shebangs across scripts
+- Inconsistent email addresses
+- No .editorconfig for formatting
+- Test scripts need documentation
+
+** Files Created This Session
+- docs/project-workflows/code-review.org - Code review workflow
+
+** Files Modified This Session
+- todo.org - Added Makefile targets, code review tasks (14 new items)
+
+** Pending User Review
+- docs/project-workflows/code-review.org (task in todo.org)
+
+** Next Steps
+- User to review code-review.org document
+- Address Priority A issues from code review
+- Delete SESSION-CONTEXT.md (root) after confirming this file is canonical
-- 
cgit v1.2.3