diff options
| -rwxr-xr-x | archsetup | 29 | ||||
| -rw-r--r-- | todo.org | 7 |
2 files changed, 15 insertions, 21 deletions
@@ -697,19 +697,6 @@ prerequisites() { --save /etc/pacman.d/mirrorlist EOF - # Skip running reflector during installation - it can cause SSH disconnections during testing - # The reflector.timer will update mirrors automatically later - # action="updating repository mirrors" && display "task" "$action" - # (reflector --connection-timeout 3 \ - # --download-timeout 3 \ - # --protocol https \ - # --age 12 \ - # --latest 20 \ - # --score 10 \ - # --fastest 5 \ - # --sort score \ - # --save /etc/pacman.d/mirrorlist > /dev/null 2>&1) - action="enabling the reflector timer" && display "task" "$action" (systemctl enable reflector.timer >> "$logfile" 2>&1) || \ error_warn "$action" "$?" @@ -1219,10 +1206,10 @@ xorg() { done # disallow vt switching or zapping the xorg server to bypass screen lock - cat << EOF > /etc/X11/xorg.conf.d/00-no-vt-or-zap.conf - Section "ServerFlags" - Option "DontVTSwitch" "True" - Option "DontZap" "True" + cat << 'EOF' > /etc/X11/xorg.conf.d/00-no-vt-or-zap.conf +Section "ServerFlags" + Option "DontVTSwitch" "True" + Option "DontZap" "True" EndSection EOF action="configuring xorg server" && display "task" "$action" @@ -1712,7 +1699,7 @@ boot_ux() { fi action="removing distro and date/time from initial screen" && display "task" "$action" - (cat /dev/null >/etc/issue) || error_warn "$action" "$?" + (: >/etc/issue) || error_warn "$action" "$?" action="preventing kernel messages on the console" && display "task" "$action" (echo "kernel.printk = 3 3 3 3" >/etc/sysctl.d/20-quiet-printk.conf) || \ @@ -1795,9 +1782,9 @@ outro() { action="comparing timestamps" && display "task" "$action" ENDTIME=$(date +%s) - totalsecs=$(($ENDTIME - $STARTTIME)) - mins=$(($totalsecs / 60)) - secs=$(($totalsecs % 60)) + totalsecs=$((ENDTIME - STARTTIME)) + mins=$((totalsecs / 60)) + secs=$((totalsecs % 60)) new_packages=$(wc -l < "$archsetup_packages") @@ -655,6 +655,13 @@ Steps: Reference: Removed from archsetup on 2025-11-15 +*** TODO [#D] Bulk shellcheck cleanup +Reviewed 2026-01-24: ~128 warnings, mostly acceptable patterns or low-priority style issues. +- SC2024 (sudo redirects) - acceptable, script runs as root +- SC2174 (mkdir -p -m) - reviewed, not a practical issue +- Various quoting warnings - high-priority ones already fixed +Run =shellcheck archsetup= periodically to check for new issues, but bulk cleanup is low priority. + ** Method 6: Add Wayland/Hyprland Desktop Alternative Currently archsetup installs only Xorg with DWM. This method adds a Wayland-based alternative using Hyprland that preserves the same workflow and keybindings while modernizing the graphics stack. |