From 2e10a8856d0bdd4c8f77c53320221ad1b8deaa13 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Thu, 13 Nov 2025 23:26:21 -0600
Subject: fix(archsetup): implement critical bug fixes and test improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit addresses several high-priority bugs and enhances the testing infrastructure:

**Bug Fixes:**
1. Add root permission check at script start to fail fast with clear error message
2. Disable debug package installation by adding --nodebug flag to all yay calls
3. Replace unsafe `git pull --force` with safe rm + fresh clone to prevent data loss
4. Add geoclue package with correct systemd service configuration for geolocation
5. Add completion marker for reliable automated test detection

**Testing Infrastructure:**
- Add comprehensive VM-based testing framework in scripts/testing/
- Fix test script pgrep infinite loop using grep bracket self-exclusion pattern
- Add network diagnostics and pre-flight checks
- Support snapshot-based testing for reproducible test runs

**Package Management:**
- Remove anki (build hangs 98+ minutes)
- Remove adwaita-color-schemes (CMake build issues)

Test Results: 0 errors, 1,363 packages installed in 40 minutes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 scripts/testing/lib/network-diagnostics.sh | 60 ++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 scripts/testing/lib/network-diagnostics.sh

(limited to 'scripts/testing/lib/network-diagnostics.sh')

diff --git a/scripts/testing/lib/network-diagnostics.sh b/scripts/testing/lib/network-diagnostics.sh
new file mode 100644
index 0000000..3f9735b
--- /dev/null
+++ b/scripts/testing/lib/network-diagnostics.sh
@@ -0,0 +1,60 @@
+#!/bin/bash
+# Network diagnostics for VM testing
+# Author: Craig Jennings <craigmartinjennings@gmail.com>
+# License: GNU GPLv3
+
+# Note: logging.sh should already be sourced by the calling script
+
+# Run quick network diagnostics
+# Args: $1 = VM IP address or hostname
+run_network_diagnostics() {
+    local vm_host="$1"
+
+    section "Pre-flight Network Diagnostics"
+
+    # Test 1: Basic connectivity
+    step "Testing internet connectivity"
+    if sshpass -p 'archsetup' ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null root@$vm_host "ping -c 3 8.8.8.8 >/dev/null 2>&1"; then
+        success "Internet connectivity OK"
+    else
+        error "No internet connectivity"
+        return 1
+    fi
+
+    # Test 2: DNS resolution
+    step "Testing DNS resolution"
+    if sshpass -p 'archsetup' ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null root@$vm_host "nslookup archlinux.org >/dev/null 2>&1"; then
+        success "DNS resolution OK"
+    else
+        error "DNS resolution failed"
+        return 1
+    fi
+
+    # Test 3: Arch mirror accessibility
+    step "Testing Arch mirror access"
+    if sshpass -p 'archsetup' ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null root@$vm_host "curl -s -I https://mirrors.kernel.org/archlinux/ | head -1 | grep -qE '(200|301)'"; then
+        success "Arch mirrors accessible"
+    else
+        error "Cannot reach Arch mirrors"
+        return 1
+    fi
+
+    # Test 4: AUR accessibility
+    step "Testing AUR access"
+    if sshpass -p 'archsetup' ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null root@$vm_host "curl -s -I https://aur.archlinux.org/ | head -1 | grep -qE '(200|405)'"; then
+        success "AUR accessible"
+    else
+        error "Cannot reach AUR"
+        return 1
+    fi
+
+    # Show network info
+    info "Network configuration:"
+    sshpass -p 'archsetup' ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null root@$vm_host \
+        "ip addr show | grep 'inet ' | grep -v '127.0.0.1'" 2>/dev/null | while read line; do
+        info "  $line"
+    done
+
+    success "Network diagnostics complete"
+    return 0
+}
-- 
cgit v1.2.3