From 364fa17f9578b51f9a8e950684ee910e911ced59 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sat, 24 Jan 2026 13:33:06 -0600 Subject: fix(archsetup): code cleanup and style fixes - Remove commented-out reflector code (timer handles updates) - Fix arithmetic expressions (remove unnecessary inner $) - Simplify file truncation (: > instead of cat /dev/null >) - Fix Xorg heredoc indentation - Add shellcheck bulk cleanup as priority D task --- todo.org | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'todo.org') diff --git a/todo.org b/todo.org index 8a7cd76..5f5f849 100644 --- a/todo.org +++ b/todo.org @@ -655,6 +655,13 @@ Steps: Reference: Removed from archsetup on 2025-11-15 +*** TODO [#D] Bulk shellcheck cleanup +Reviewed 2026-01-24: ~128 warnings, mostly acceptable patterns or low-priority style issues. +- SC2024 (sudo redirects) - acceptable, script runs as root +- SC2174 (mkdir -p -m) - reviewed, not a practical issue +- Various quoting warnings - high-priority ones already fixed +Run =shellcheck archsetup= periodically to check for new issues, but bulk cleanup is low priority. + ** Method 6: Add Wayland/Hyprland Desktop Alternative Currently archsetup installs only Xorg with DWM. This method adds a Wayland-based alternative using Hyprland that preserves the same workflow and keybindings while modernizing the graphics stack. -- cgit v1.2.3