From 830e03f182e6965649bc59b0cd0d9659afed0448 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Mon, 11 May 2026 17:19:56 -0500
Subject: chore: track findings from the 2026-05-11 VM test run

I added a TODO for the 7 errors logged during the run. A few look real: fc-cache and dconf hit exit 127, and gamemode failed for the user. A couple look like VM/nf_tables artifacts I want to confirm on bare metal.

I moved the rlwrap-not-installed investigation to Resolved (DONE). rlwrap installs cleanly in a fresh VM, so the ratio glitch does not reproduce. The test-infra fix from the previous commit is also logged as DONE in Resolved.
---
 todo.org | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/todo.org b/todo.org
index 724ea2d..c549464 100644
--- a/todo.org
+++ b/todo.org
@@ -205,8 +205,15 @@ See Framework community notes on logind.conf and sleep.conf settings
 ** TODO [#A] Build CI/CD pipeline that runs archsetup on every commit
 Core automation infrastructure - enables continuous validation
 
-*** TODO [#B] Investigate rlwrap not installed after archsetup run
-rlwrap is declared in archsetup (Emacs Dependencies section, line 1779) but was not installed on this machine after archsetup ran. Manually installed 2026-02-06. When CI/CD is running, verify that all packages in the Emacs Dependencies section are actually installed after a full test run. May indicate a broader issue with packages being skipped silently.
+** TODO [#B] Fix install errors surfaced by the 2026-05-11 VM test run
+The 2026-05-11 =make test= run completed (=ARCHSETUP_EXECUTION_COMPLETE=) but logged 7 errors. Triage and fix the real ones; confirm or rule out the suspected VM artifacts. Source: =test-results/20260511-151721/archsetup-output.log=.
+- refreshing font cache — exit 127 (=fc-cache= not on PATH at that step?) — likely a real ordering bug
+- configuring GTK file chooser — exit 1
+- configuring GNOME interface settings in dconf — exit 127 (=dconf= not available yet?) — likely a real ordering bug
+- enabling firewall — exit 1: =iptables v1.8.13 (nf_tables): Could not fetch rule set generation id: Invalid argument= — likely a VM-kernel/nf_tables artifact; confirm on bare metal
+- verifying firewall is active — exit 1 (follow-on from the firewall-enable error)
+- enabling gamemode for user — exit 1 → step "gaming" FAILED — non-critical
+- tidaler (AUR) — logged in the error summary with exit code 0 (odd; logging quirk or transient AUR build noise?)
 
 ** TODO [#A] Generate recovery scripts from test failures
 Auto-create post-install fix scripts for failed packages - makes failures actionable
@@ -596,3 +603,13 @@ abandoned and broken against current Hyprland. Options: fork and fix hyprlandMon
 script a pseudo-monocle using fullscreen 1, or wait for a maintained plugin. Lower priority since
 stash-window ($mod+O / $mod+Shift+O) covers the main use case. More important for laptop installs.
 Resolved: Hyprland 0.54 added native monocle layout. Bound to $mod SHIFT M.
+
+** DONE [#B] Investigate rlwrap not installed after archsetup run
+CLOSED: [2026-05-11 Mon]
+rlwrap was declared in archsetup (Emacs Dependencies) but missing after a run on ratio (2026-02-06).
+The 2026-05-11 VM test run shows it installs cleanly in a fresh install (=...installing rlwrap via pacman @ 15:36:55=; =rlwrap 0.48-1= in the captured package list), so it doesn't reproduce — likely a one-off / machine-specific glitch on ratio, not a systemic skip. Closing; reopen if it recurs.
+
+** DONE [#C] Remove stale hyprpm/plugins validations; make run-test.sh tolerant of validation failures
+CLOSED: [2026-05-11 Mon]
+The 2026-05-11 VM test aborted because =validate_hyprland_plugins= in =scripts/testing/lib/validation.sh= checked for =~/.local/bin/hyprland-plugins-setup=, which was deliberately removed in dd543e3 (=feat(hyprland): remove plugins, add layout cycling=; Hyprland 0.54 brings the layouts into core). The function's =return 1= under run-test.sh's =set -e= killed the run before the test report was written or the VM cleaned up.
+Fix: deleted =validate_hyprland_plugins= and =validate_hyprpm_hook= (the hyprpm pacman hook was removed in the same commit) plus their calls in =validate_window_manager=; disabled errexit in =run-test.sh= from the validation phase onward so a failed check is counted (=VALIDATION_FAILED=) instead of fatal — the script signals pass/fail via its exit code at the end. Verified with =bash -n=; the next =make test= run confirms the count-not-abort behavior.
-- 
cgit v1.2.3