From 14eecb5b8e76cf1b1de20643d496dc94cfdce0ab Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Mon, 11 May 2026 17:19:56 -0500 Subject: fix(testing): drop stale plugin checks, count failed validations validate_hyprland_plugins and validate_hyprpm_hook checked for the hyprland-plugins-setup script and the hyprpm pacman hook, both removed in 4a3056a (Hyprland 0.54 brings the layouts into core). I deleted the two functions and their calls in validate_window_manager. I also disabled errexit in run-test.sh from the validation phase onward, so one failed check is counted in VALIDATION_FAILED instead of aborting the run before the report or VM cleanup. About 16 validations across the file do a bare `return 1` after `validation_fail`; any of them firing under the previous behavior would have killed the harness mid-run. --- scripts/testing/run-test.sh | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'scripts/testing/run-test.sh') diff --git a/scripts/testing/run-test.sh b/scripts/testing/run-test.sh index d1b4566..c0eaf50 100755 --- a/scripts/testing/run-test.sh +++ b/scripts/testing/run-test.sh @@ -256,7 +256,15 @@ copy_from_vm "/var/log/archsetup-installed-packages.txt" "$TEST_RESULTS_DIR/" "$ capture_post_install_state "$TEST_RESULTS_DIR" # Run comprehensive validation -# This uses the validation.sh library for all checks +# This uses the validation.sh library for all checks. +# +# From here to the end of the script, errexit is disabled on purpose: the +# validation functions are designed to fail-and-count (see VALIDATION_FAILED) +# rather than abort, and the analysis/report-generation steps below can also +# legitimately return non-zero. With `set -e` active, a single failed check +# would kill the run before the test report is written or the VM is cleaned +# up. Pass/fail is signalled explicitly by the exit code at the bottom. +set +e run_all_validations validate_all_services -- cgit v1.2.3