From 618e6cce0b1662f50c6e766bba7e11b6d6952532 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Wed, 20 May 2026 12:02:47 -0500
Subject: fix: correct a POSIX-sh bashism in init and document two SC2034 cases

init runs under #!/bin/sh but used $(<file) to read /etc/hostname, a bashism that breaks on a strict POSIX sh. I switched it to $(cat) and quoted $interface_up in the same script.

The two VM_IP assignments in the test scripts are read by the sourced validation.sh, which shellcheck can't follow, so they now carry a documented disable=SC2034 instead of a bare suppression. The rest of the shellcheck findings across the scripts are intentional (word-splitting on $SSH_OPTS, integer tests in [ ]) or already accepted, so I left them alone.
---
 scripts/testing/run-test-baremetal.sh | 1 +
 scripts/testing/run-test.sh           | 1 +
 2 files changed, 2 insertions(+)

(limited to 'scripts/testing')

diff --git a/scripts/testing/run-test-baremetal.sh b/scripts/testing/run-test-baremetal.sh
index 3beaefc..b6d1ab1 100755
--- a/scripts/testing/run-test-baremetal.sh
+++ b/scripts/testing/run-test-baremetal.sh
@@ -94,6 +94,7 @@ cleanup_baremetal() {
 trap cleanup_baremetal EXIT
 
 # Override VM_IP for validation.sh ssh_cmd function
+# shellcheck disable=SC2034  # consumed by the sourced validation.sh
 VM_IP="$TARGET_HOST"
 
 # Initialize logging
diff --git a/scripts/testing/run-test.sh b/scripts/testing/run-test.sh
index 18f4fdf..a02412c 100755
--- a/scripts/testing/run-test.sh
+++ b/scripts/testing/run-test.sh
@@ -84,6 +84,7 @@ ARCHZFS_INBOX="$HOME/code/archzfs/inbox"
 ARCHSETUP_VM_CONF="$SCRIPT_DIR/archsetup-vm.conf"
 
 # Set VM_IP for validation.sh backward compatibility
+# shellcheck disable=SC2034  # consumed by the sourced validation.sh
 VM_IP="localhost"
 
 # Initialize logging and VM paths
-- 
cgit v1.2.3