aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* fix: load convert-org-contacts-birthdays from load-pathCraig Jennings2026-04-211-3/+1
| | | | | | The previous form computed the file path at compile time via (file-name-directory (or load-file-name buffer-file-name)). Under emacs --batch byte-compile, both load-file-name and buffer-file-name are nil, so the inner expand-file-name call signaled "Wrong type argument: stringp, nil" and blocked validate-el.sh from accepting any edit to chime-org-contacts.el. convert-org-contacts-birthdays.el lives next to chime-org-contacts.el, so it is already on the load-path whenever chime-org-contacts is loadable. Drop the explicit path argument and let require resolve via load-path.
* test: add unit tests for chime--render-modeline-stringCraig Jennings2026-04-211-0/+52
| | | | | | | | | | Five tests covering Normal and Boundary cases. Normal: SOONEST branch applies chime-modeline-format to the event-text. Normal: no SOONEST plus UPCOMING binds mouse-1 (open calendar) and mouse-3 (jump to event). Normal: no SOONEST and no UPCOMING binds only mouse-1, and the tooltip is the no-events message. Boundary: returns nil when no SOONEST and chime-modeline-no-events-text is nil. Boundary: SOONEST branch renders regardless of whether chime-modeline-no-events-text is set. The orchestrator chime--update-modeline already exercises these paths via test-chime-update-modeline.el. These direct unit tests give the helper its own coverage.
* refactor: extract chime--render-modeline-string from chime--update-modelineCraig Jennings2026-04-211-25/+30
| | | | | | | | chime--update-modeline grew to mix orchestration with the modeline-string formation logic. Extract the formation block into its own helper so the orchestrator reads as pure orchestration: build upcoming, find soonest, render, force update. The helper handles both branches. When a soonest event is in the modeline window, format and propertize via chime--propertize-modeline-string. Otherwise, when chime-modeline-no-events-text is set, propertize that with the appropriate tooltip and click handlers (mouse-1 always, mouse-3 only when there are upcoming events to jump to). The orchestrator drops from 45 to 25 lines.
* fix(hooks): run validate-el test phase from tests/ directoryCraig Jennings2026-04-211-1/+4
| | | | | | Test files start with (require 'test-bootstrap (expand-file-name "test-bootstrap.el")). The expand-file-name call resolves against default-directory, which in batch mode is the directory the shell was in when emacs started. The hook ran emacs from the project root, so the require looked for the bootstrap at the project root and could not find it. Every Edit or Write to a test file failed the hook. The fix is to cd into PROJECT_ROOT/tests inside the subshell before launching emacs, so the bootstrap require resolves to tests/test-bootstrap.el where the file actually lives.
* docs: expand custom predicate examples in READMECraig Jennings2026-04-201-7/+22
| | | | | | | Fill out the custom-predicate-filtering section with the two motivating examples from the surrounding prose (specific-file whitelist, weekend work silencer) plus a priority-A whitelist, and tighten the defensive handling of buffer-file-name for indirect buffers.
* chore: ignore .stignore (syncthing)Craig Jennings2026-04-201-0/+1
|
* restructure: move docs/ to .ai/ + sync latest templateCraig Jennings2026-04-201-1/+1
| | | | | Per claude-templates c36fd14. Claude tooling moves to hidden .ai/; project-level docs/ reserved for real documentation.
* chore(claude): sync validate-el.sh JSON channel + pairwise rule from rulesetsCraig Jennings2026-04-192-9/+44
|
* chore: sync testing rules — pyramid, overmocking, ↵Craig Jennings2026-04-192-0/+130
| | | | refactor-for-testability, interactive/internal split
* chore: sync elisp-testing.md (testutil pattern generalized)Craig Jennings2026-04-191-3/+3
|
* chore: sync bundle — add commits.md rule, attribution suppressionCraig Jennings2026-04-192-0/+70
| | | | | | - New .claude/rules/commits.md: no AI attribution, conventional prefixes. - settings.json: attribution.commit and attribution.pr empty strings. - CLAUDE.md template refreshed to reference commits.md.
* chore: add Claude Code ruleset via ~/code/rulesets install-elispCraig Jennings2026-04-198-0/+564
| | | | | | | | | | | | | | | | | | Installs the Elisp ruleset from the rulesets repo: - CLAUDE.md (project instructions template) - .claude/rules/ (testing, verification, elisp, elisp-testing) - .claude/hooks/validate-el.sh (check-parens + byte-compile + run matching tests on every .el edit via PostToolUse) - .claude/settings.json (permission allowlist + hook wiring) - githooks/pre-commit (secret scan + staged-file paren check) core.hooksPath set to githooks/ so the pre-commit activates automatically. Hooks use \$CLAUDE_PROJECT_DIR with a script-relative fallback, so a fresh clone works without path edits. .gitignore extended with personal-override entries (settings.local.json, .cache/) and byte-compile artifacts (*.elc, *.eln).
* Improve README quick start, manual install, and filtering docsCraig Jennings2026-04-041-59/+60
| | | | | | | | Rewrote Quick Start to show minimal config (just chime-mode 1) with defaults overview and modeline interaction guide. Expanded manual install with git clone steps. Fixed TOC nav links, made tag filter examples consistent, added custom predicate motivation, removed redundant Basic Event subsection.
* Add personality and reorganize READMECraig Jennings2026-04-041-264/+135
| | | | | | | Add Douglas Adams epigraph, funny event names throughout, voice in installation and history sections. Consolidate org-contacts into new Integrations section with org-gcal guide. Trim verbose all-day events interaction examples. Add severity, sound format, and icon docs.
* Fix TOC formatting in TESTING.orgCraig Jennings2026-04-041-3/+1
|
* Add table of contents to TESTING.orgCraig Jennings2026-04-041-0/+4
|
* Rewrite TESTING.org with current test infrastructureCraig Jennings2026-04-041-176/+275
| | | | | | Replaced stale 339-test/23-file doc with current state (645 tests, 53 files). Documents test-bootstrap.el, testutil libraries, Makefile consolidation, and all convenience macros.
* Remove duplicate COPYING fileCraig Jennings2026-04-041-674/+0
| | | | | LICENSE and COPYING were identical. Keep LICENSE since README links to it and GitHub recognizes it automatically.
* Consolidate Makefiles and update TESTING.orgCraig Jennings2026-04-042-129/+73
| | | | | | Root Makefile now delegates to tests/Makefile. Fixed stale UNIT_TESTS/INTEGRATION_TESTS definitions, added test-name target, switched to per-file test execution for better isolation.
* Add tests for chime-environment-regexCraig Jennings2026-04-041-0/+62
| | | | | Verify the regex matches all default variable names, picks up additional user-configured regexes, and handles empty additional list.
* Decompose chime--debug-notification-filtering into step functionsCraig Jennings2026-04-041-71/+71
| | | | | | | | | The 120-line diagnostic function is now a 30-line coordinator calling four focused helpers: - chime--debug-filter-check-timestamp - chime--debug-filter-check-time-match - chime--debug-filter-check-interval - chime--debug-filter-check-pipeline
* Remove unused chime--today functionCraig Jennings2026-04-042-88/+0
| | | | Defined and tested but never called from any production code.
* Bundle multiple day-wide events into a single notificationCraig Jennings2026-04-042-2/+67
| | | | | | | | | | When all-day event alert times trigger, multiple events (overdue tasks, birthdays, holidays) previously fired individual notifications — one sound and one popup each. With 8-10 events this was overwhelming. Now multiple day-wide events are bundled into a single notification with all messages joined by newlines. Single events still notify normally without bundling.
* Restructure README and address review commentsCraig Jennings2026-04-043-151/+828
| | | | | | | | | | | | | | - Remove About section (merged into intro) - Rename Credits to History, fold Migration under it - Fold Manual Check and Known Limitations under Usage - Fold Full Example Configuration under Configuration - Add straight.el and quelpa install methods - Move requirements into Installation with auto-deps note - Add notification daemon check to troubleshooting - Add Development subsection with clone/lint/issues info - Add LICENSE file (GPL-3.0) - Update nav bar to match new structure - Fix startup integration test for new modeline error state
* Add horizontal nav bar and Made for GNU Emacs badge to READMECraig Jennings2026-04-042-20/+5
| | | | | Replace vertical table of contents with horizontal section links matching wttrin README style. Add Made for GNU Emacs badge.
* Show modeline icon immediately on chime-mode enableCraig Jennings2026-04-042-11/+92
| | | | | | | | | Previously chime-modeline-string was nil until the first async check completed (~10-15 seconds after startup). Now the icon appears instantly with a "waiting for first event check" tooltip. On validation or async failure, the icon stays visible and the tooltip updates to show the error state instead of going blank.
* Default modeline lighter to empty stringCraig Jennings2026-04-042-12/+10
| | | | | | The bell emoji lighter was redundant alongside the alarm clock event display in global-mode-string. One icon is enough. Users who want a separate mode indicator can set chime-modeline-lighter.
* Improve defaults: 2-hour modeline window, notify at event timeCraig Jennings2026-04-042-9/+12
| | | | | | | | | | Bump chime-modeline-lookahead-minutes from 60 to 120 so events within the next 2 hours show in the modeline. The old 60-minute default hid events most users would expect to see. Add (0 . high) to default chime-alert-intervals so users get a notification at event time in addition to 10 minutes before. The single-notification default meant a missed alert had no backup.
* Clean up README prose: remove AI-isms, fix typoCraig Jennings2026-04-041-20/+18
| | | | | | | | Remove promotional language (pleasant, extensive, comprehensive), flatten rule-of-three constructions, replace "interplay" heading, simplify tactical/strategic framing, drop redundant blacklist justification. Fix "begain" typo in credits. Trim duplicated Testing/Development pointers.
* Update README for accuracy and completenessCraig Jennings2026-04-041-41/+126
| | | | | | | | | | | | | | | | Fix stale content: - Tooltip lookahead default: 8760 hours -> 168 (1 week) - Test count: 505 -> 600+ - Emacs version: 26.1+ -> 27.1+ (matches Package-Requires) - Troubleshooting: fix stale convert-contacts-to-file reference to match current in-place conversion workflow Add missing documentation: - Custom predicate filtering with examples - chime-max-consecutive-failures, chime-validation-max-retries - chime-extra-alert-plist, chime-additional-environment-regexes - chime-refresh-modeline command - Debug mode section in Troubleshooting with all diagnostic commands
* Add comments for non-obvious code patternsCraig Jennings2026-04-041-7/+15
| | | | | | | | Clarify: dash cartesian product pipeline in chime--notifications, butlast 2 dropping USEC/PSEC from time values, Emacs time type guard, upcoming-events item structure, rx macroexpand for async env injection, backquoted lambda subprocess boundary, and org-end-of-meta-data nil argument meaning.
* Remove dead code and reduce default tooltip lookahead to 1 weekCraig Jennings2026-04-043-38/+6
| | | | | | | | | | | Remove chime--agenda-buffer-name (unused variable) and chime--extract-birthday-year (superseded by chime--parse-birthday). Reduce chime-tooltip-lookahead-hours from 8760 (1 year) to 168 (1 week). The 1-year default caused org-agenda-list to scan a 365-day span every check cycle, which is slow for large org collections. The tooltip only shows 5 events, so a week is sufficient for most users.
* Hoist loop-invariant computations and remove redundant sortCraig Jennings2026-04-041-68/+53
| | | | | | | | | Performance improvements with no behavioral change: - chime--group-events-by-day: hoist decode-time calls before loop - chime-event-has-any-passed-time: compute today-start once, not per timestamp - chime-event-is-today: same pattern - chime--build-upcoming-events-list: remove first sort (discarded by hash dedup) - chime--process-notifications: use -mapcat instead of -map + -flatten
* Nil chime--timer after cancellation in chime--stopCraig Jennings2026-04-042-0/+12
| | | | | The timer variable was left pointing at a cancelled timer object. Now set to nil so state accurately reflects no active timer.
* Fix file headers: correct copyright years, add missing headerCraig Jennings2026-04-0412-11/+28
| | | | | New files created in 2026 should have Copyright (C) 2026, not 2024-2026. Add standard copyright/license header to test-bootstrap.el.
* Extract days-until calculation from chime--day-wide-notification-textCraig Jennings2026-04-041-27/+22
| | | | | | Move the all-day timestamp date arithmetic into chime--days-until-event. The notification text function now reads clearly as a cond dispatch over today/advance-notice/fallback cases.
* Extract validation retry logic from chime-check into chime--maybe-validateCraig Jennings2026-04-041-26/+25
| | | | | | The validation/retry state machine was 30 lines embedded in chime-check. Now chime--maybe-validate returns t if OK to proceed, nil to skip. chime-check is reduced to 12 lines: validate, then fetch-and-process.
* Extract display logic from chime-validate-configurationCraig Jennings2026-04-041-14/+14
| | | | | | Move interactive display (message/display-warning calls) into chime--display-validation-results. The validation function stays focused on collecting issues; display is a separate concern.
* Extract test boilerplate into shared test-bootstrap.elCraig Jennings2026-04-0451-656/+96
| | | | | | | | | | All 50 test files that load chime.el repeated the same 8-line initialization block (package-initialize, ert, dash, alert, async, org-agenda, chime load). Replace with a single require of test-bootstrap.el. Also fix test-make-upcoming-item name collision between test-chime-make-tooltip.el and test-chime--deduplicate-events-by-title.el.
* Extract three timestamp strategies from chime--extract-timeCraig Jennings2026-04-041-54/+59
| | | | | | | | | Decompose the 72-line function into focused helpers: - chime--extract-gcal-timestamps: org-gcal drawer extraction - chime--extract-property-timestamps: SCHEDULED/DEADLINE properties - chime--extract-plain-timestamps: plain body timestamps chime--extract-time is now a 12-line dispatcher.
* Consolidate birthday utilities into convert-org-contacts-birthdaysCraig Jennings2026-04-042-196/+16
| | | | | | | | | | chime-org-contacts.el duplicated parse, format, and insert-after-drawer functions from convert-org-contacts-birthdays.el. Remove the duplicates and have chime-org-contacts require the convert module instead. Removes ~35 lines of duplicated code. The finalize function now delegates to chime--insert-birthday-timestamp-after-drawer with condition-case for graceful handling of invalid birthday formats during capture.
* Add integration test for chime-mode deactivation cleanupCraig Jennings2026-04-041-0/+10
| | | | | Verifies disabling chime-mode removes chime-modeline-string from global-mode-string and sets it to nil.
* Add integration test for chime-mode modeline registrationCraig Jennings2026-04-041-0/+61
| | | | | Verifies enabling chime-mode adds chime-modeline-string to global-mode-string so events appear in the modeline.
* Add 94 tests across 10 new test files and fix 2 bugsCraig Jennings2026-04-0411-7/+1553
| | | | | | | | | | | | New test coverage for previously untested functions: - filter-day-wide-events, time utilities, day-wide time matching - make-tooltip, event-is-today, get-tags, done-keywords-predicate - extract-title, propertize-modeline-string, warn-persistent-failures - log-silently Bug fixes discovered by new tests: - Fix pluralization in no-events tooltip ("1 hours" -> "1 hour", etc.) - Fix chime--get-tags returning ("") instead of nil for untagged headings
* Add test config macros and migrate startup tests to use themCraig Jennings2026-02-262-155/+186
| | | | | | Add with-chime-config and with-org-event-file macros to testutil-events.el, replacing the manual defvar/save/restore pattern with let-bindings that auto-restore on exit. Migrate test-integration-startup.el as first adopter.
* Add persistent async failure warnings after consecutive errorsCraig Jennings2026-02-231-2/+30
| | | | | | Tracks consecutive async check failures and displays a warning via display-warning when the threshold is reached (default 5). Resets on any successful check.
* Use locate-library fallback for sound file path resolutionCraig Jennings2026-02-231-1/+4
| | | | | Adds locate-library as a fallback between load-file-name and buffer-file-name for more robust path resolution in MELPA installs.
* Improve org-agenda-files validation to distinguish files from directoriesCraig Jennings2026-02-232-11/+14
|
* Include event title in timestamp parse error messagesCraig Jennings2026-02-231-8/+13
| | | | | | | Add optional context parameter to chime--timestamp-parse and pass the org heading title from chime--extract-time. Error messages now show which event failed, e.g. "Failed to parse timestamp '...' in 'Team Meeting': ..."
* Fix flaky validation failure test by resetting shared stateCraig Jennings2026-02-231-0/+6
| | | | | | The test checks that chime-modeline-string and chime--upcoming-events are nil after early return, but previous tests could leave them set. Reset these and chime--validation-retry-count at test start.