From 0b65f607102c12260c7cca5df3d8586c2b1a24bd Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 5 May 2026 12:24:56 -0500 Subject: refactor!: demote chime-validation-max-retries to private defvar MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is an internal startup-timing parameter, not a knob real users have reason to tune through `M-x customize'. I demoted it from defcustom to defvar and renamed it to `chime--validation-max-retries' to make the private status explicit. Anyone who was overriding it can keep doing so with `setq' (the variable still exists, just under the new name). The three customize-time validation tests went away with the defcustom — nothing left to validate at customize-time once it stops being a customize-target. The setter helper still applies to the other five numeric defcustoms. Test files that referenced the variable (`test-chime-validation-retry.el', `test-integration-chime-mode.el') were renamed mechanically along with the source. Breaking change: `(setq chime-validation-max-retries N)' becomes `(setq chime--validation-max-retries N)' if you actually had it. Most users won't have touched it. --- tests/test-chime-numeric-defcustom-setters.el | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) (limited to 'tests/test-chime-numeric-defcustom-setters.el') diff --git a/tests/test-chime-numeric-defcustom-setters.el b/tests/test-chime-numeric-defcustom-setters.el index 03d7810..7fb5afa 100644 --- a/tests/test-chime-numeric-defcustom-setters.el +++ b/tests/test-chime-numeric-defcustom-setters.el @@ -161,26 +161,8 @@ 'chime-max-consecutive-failures -1) :type 'user-error))) -;;;; chime-validation-max-retries — integer >= 0 - -(ert-deftest test-chime-validation-max-retries-accepts-zero () - "Normal: 0 means show errors immediately without retrying (per docstring)." - (let ((chime-validation-max-retries 3)) - (customize-set-variable 'chime-validation-max-retries 0) - (should (= 0 chime-validation-max-retries)))) - -(ert-deftest test-chime-validation-max-retries-accepts-positive () - "Normal: positive integer is valid." - (let ((chime-validation-max-retries 3)) - (customize-set-variable 'chime-validation-max-retries 5) - (should (= 5 chime-validation-max-retries)))) - -(ert-deftest test-chime-validation-max-retries-rejects-negative () - "Error: negative retry count is meaningless." - (let ((chime-validation-max-retries 3)) - (should-error (customize-set-variable - 'chime-validation-max-retries -1) - :type 'user-error))) +;; Note: `chime--validation-max-retries' was demoted from defcustom to +;; defvar in 0.8 — no customize-time setter, no validation tests here. (provide 'test-chime-numeric-defcustom-setters) ;;; test-chime-numeric-defcustom-setters.el ends here -- cgit v1.2.3