From 36491e1c4d2b04196ab18d275b834933e8cae2fb Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Fri, 6 Feb 2026 13:51:36 -0600 Subject: fix(test): add missing testutil require for sanitize-org-body tests --- modules/video-audio-recording.el | 8 +++--- tests/test-calendar-sync--sanitize-org-body.el | 1 + tests/test-integration-recording-modeline-sync.el | 30 +++++++++++----------- .../test-integration-recording-toggle-workflow.el | 10 ++++---- ...est-video-audio-recording-modeline-indicator.el | 8 +++--- 5 files changed, 29 insertions(+), 28 deletions(-) diff --git a/modules/video-audio-recording.el b/modules/video-audio-recording.el index 4e57951d..5e812881 100644 --- a/modules/video-audio-recording.el +++ b/modules/video-audio-recording.el @@ -130,16 +130,16 @@ If nil, will auto-detect on first use.") (defun cj/recording-modeline-indicator () "Return modeline string showing active recordings. -Shows 󰍬 (microphone) for audio, 󰃽 (camcorder) for video. +Shows 🎀 (microphone) for audio, 🎬 (clapper board) for video. Checks if process is actually alive, not just if variable is set." (let ((audio-active (and cj/audio-recording-ffmpeg-process (process-live-p cj/audio-recording-ffmpeg-process))) (video-active (and cj/video-recording-ffmpeg-process (process-live-p cj/video-recording-ffmpeg-process)))) (cond - ((and audio-active video-active) " 󰍬󰃽 ") - (audio-active " 󰍬 ") - (video-active " 󰃽 ") + ((and audio-active video-active) " 🎀🎬 ") + (audio-active " 🎀 ") + (video-active " 🎬 ") (t "")))) ;;; ============================================================ diff --git a/tests/test-calendar-sync--sanitize-org-body.el b/tests/test-calendar-sync--sanitize-org-body.el index c85e763c..c38c277e 100644 --- a/tests/test-calendar-sync--sanitize-org-body.el +++ b/tests/test-calendar-sync--sanitize-org-body.el @@ -8,6 +8,7 @@ ;;; Code: (require 'ert) +(require 'testutil-calendar-sync) (require 'calendar-sync) ;;; Normal Cases diff --git a/tests/test-integration-recording-modeline-sync.el b/tests/test-integration-recording-modeline-sync.el index 6bb0e99e..49d3c57d 100644 --- a/tests/test-integration-recording-modeline-sync.el +++ b/tests/test-integration-recording-modeline-sync.el @@ -68,7 +68,7 @@ When user toggles audio recording on: 1. Process is created -2. Modeline indicator updates to show 󰍬 (mic icon) +2. Modeline indicator updates to show 🎀(mic icon) 3. State is in sync immediately (not delayed) Components integrated: @@ -94,7 +94,7 @@ Validates: (cj/audio-recording-toggle nil) ;; Immediately after toggle: modeline should show recording - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) ;; Process should be alive (should (process-live-p cj/audio-recording-ffmpeg-process))) @@ -127,7 +127,7 @@ Validates: ;; Start recording (cj/audio-recording-toggle nil) - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) ;; Stop recording (cj/audio-recording-toggle nil) @@ -150,7 +150,7 @@ Components integrated: Validates: - Video recording follows same sync pattern as audio -- Modeline shows 󰃽correctly" +- Modeline shows 🎬 correctly" (test-integration-modeline-setup) (unwind-protect (cl-letf (((symbol-function 'file-directory-p) @@ -164,7 +164,7 @@ Validates: ;; Start video (cj/video-recording-toggle nil) - (should (equal " 󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎬 " (cj/recording-modeline-indicator))) ;; Stop video (cj/video-recording-toggle nil) @@ -201,15 +201,15 @@ Validates: ;; State 2: Audio only (cj/audio-recording-toggle nil) - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) ;; State 3: Both (cj/video-recording-toggle nil) - (should (equal " 󰍬󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎀🎬 " (cj/recording-modeline-indicator))) ;; State 4: Video only (stop audio) (cj/audio-recording-toggle nil) - (should (equal " 󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎬 " (cj/recording-modeline-indicator))) ;; State 5: None (stop video) (cj/video-recording-toggle nil) @@ -249,7 +249,7 @@ Validates: (cj/audio-recording-toggle nil) ;; Immediately after start: should show recording - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) ;; Wait for process to exit and sentinel to run (sit-for 0.3) @@ -323,7 +323,7 @@ Validates: (dotimes (_i 5) ;; Start (cj/audio-recording-toggle nil) - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) (should cj/audio-recording-ffmpeg-process) ;; Stop @@ -357,23 +357,23 @@ Validates: ;; Start audio (cj/audio-recording-toggle nil) - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) ;; Add video - modeline should combine (cj/video-recording-toggle nil) - (should (equal " 󰍬󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎀🎬 " (cj/recording-modeline-indicator))) ;; Stop audio - video indicator should persist (cj/audio-recording-toggle nil) - (should (equal " 󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎬 " (cj/recording-modeline-indicator))) ;; Start audio again - should recombine (cj/audio-recording-toggle nil) - (should (equal " 󰍬󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎀🎬 " (cj/recording-modeline-indicator))) ;; Stop video - audio indicator should persist (cj/video-recording-toggle nil) - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) ;; Stop audio - should be empty (cj/audio-recording-toggle nil) diff --git a/tests/test-integration-recording-toggle-workflow.el b/tests/test-integration-recording-toggle-workflow.el index 0e000b68..e73ef87e 100644 --- a/tests/test-integration-recording-toggle-workflow.el +++ b/tests/test-integration-recording-toggle-workflow.el @@ -128,7 +128,7 @@ Validates: (should (string-match-p "test-monitor" ffmpeg-cmd)) ;; Verify modeline shows recording - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) ;; STEP 2: Second toggle - should stop recording (cj/audio-recording-toggle nil) @@ -222,7 +222,7 @@ Validates: ;; Verify setup and recording (should setup-called) (should cj/video-recording-ffmpeg-process) - (should (equal " 󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎬 " (cj/recording-modeline-indicator))) ;; Stop recording (cj/video-recording-toggle nil) @@ -267,7 +267,7 @@ Validates: ;; Verify both are recording (should cj/audio-recording-ffmpeg-process) (should cj/video-recording-ffmpeg-process) - (should (equal " 󰍬󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎀🎬 " (cj/recording-modeline-indicator))) ;; Stop audio only (cj/audio-recording-toggle nil) @@ -275,7 +275,7 @@ Validates: ;; Verify only video still recording (should (null cj/audio-recording-ffmpeg-process)) (should cj/video-recording-ffmpeg-process) - (should (equal " 󰃽 " (cj/recording-modeline-indicator))) + (should (equal " 🎬 " (cj/recording-modeline-indicator))) ;; Stop video (cj/video-recording-toggle nil) @@ -325,7 +325,7 @@ Validates: ;; Verify recording started (should cj/audio-recording-ffmpeg-process) - (should (equal " 󰍬 " (cj/recording-modeline-indicator))) + (should (equal " 🎀 " (cj/recording-modeline-indicator))) ;; Wait for process to exit (sentinel should run) (sit-for 0.3) diff --git a/tests/test-video-audio-recording-modeline-indicator.el b/tests/test-video-audio-recording-modeline-indicator.el index f717af7f..88694cff 100644 --- a/tests/test-video-audio-recording-modeline-indicator.el +++ b/tests/test-video-audio-recording-modeline-indicator.el @@ -45,7 +45,7 @@ (let ((fake-process (make-process :name "test-audio" :command '("sleep" "1000")))) (setq cj/audio-recording-ffmpeg-process fake-process) (let ((result (cj/recording-modeline-indicator))) - (should (equal " 󰍬 " result))) + (should (equal " 🎀 " result))) (delete-process fake-process)) (test-modeline-indicator-teardown))) @@ -56,7 +56,7 @@ (let ((fake-process (make-process :name "test-video" :command '("sleep" "1000")))) (setq cj/video-recording-ffmpeg-process fake-process) (let ((result (cj/recording-modeline-indicator))) - (should (equal " 󰃽 " result))) + (should (equal " 🎬 " result))) (delete-process fake-process)) (test-modeline-indicator-teardown))) @@ -69,7 +69,7 @@ (setq cj/audio-recording-ffmpeg-process audio-proc) (setq cj/video-recording-ffmpeg-process video-proc) (let ((result (cj/recording-modeline-indicator))) - (should (equal " 󰍬󰃽 " result))) + (should (equal " 🎀🎬 " result))) (delete-process audio-proc) (delete-process video-proc)) (test-modeline-indicator-teardown))) @@ -115,7 +115,7 @@ (delete-process dead-proc) (sit-for 0.1) (let ((result (cj/recording-modeline-indicator))) - (should (equal " 󰃽 " result))) + (should (equal " 🎬 " result))) (delete-process alive-proc)) (test-modeline-indicator-teardown))) -- cgit v1.2.3