From d7cc8638562daceb48aa8895cde4e057d3c25f6b Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Mon, 3 Nov 2025 16:15:24 -0600
Subject: test: Add unit tests for music config and org-contacts functions

Add comprehensive unit tests for various Emacs Lisp functions,
covering M3U file handling, music file validation, and contact
capture template finalization:

- Tests for appending tracks to M3U files Tests for recursive music
- collection Tests for completion table creation Tests for
- extracting M3U basenames and files Tests for M3U file parsing
- Tests for filename sanitization Tests for directory and file
- validity checks Tests for org-contacts capture template
- finalization

Each test validates normal, boundary, and error conditions. These
tests improve code reliability by verifying expected behavior across
a range of scenarios.
---
 tests/test-music-config--safe-filename.el | 97 +++++++++++++++++++++++++++++++
 1 file changed, 97 insertions(+)
 create mode 100644 tests/test-music-config--safe-filename.el

(limited to 'tests/test-music-config--safe-filename.el')

diff --git a/tests/test-music-config--safe-filename.el b/tests/test-music-config--safe-filename.el
new file mode 100644
index 00000000..8105ee15
--- /dev/null
+++ b/tests/test-music-config--safe-filename.el
@@ -0,0 +1,97 @@
+;;; test-music-config--safe-filename.el --- Tests for filename sanitization -*- coding: utf-8; lexical-binding: t; -*-
+;;
+;; Author: Craig Jennings <c@cjennings.net>
+;;
+;;; Commentary:
+;; Unit tests for cj/music--safe-filename function.
+;; Tests the pure helper that sanitizes filenames by replacing invalid chars.
+;;
+;; Test organization:
+;; - Normal Cases: Valid filenames unchanged, spaces replaced
+;; - Boundary Cases: Special chars, unicode, slashes, consecutive invalid chars
+;; - Error Cases: Nil input
+;;
+;;; Code:
+
+(require 'ert)
+
+;; Stub missing dependencies before loading music-config
+(defvar-keymap cj/custom-keymap
+  :doc "Stub keymap for testing")
+
+;; Load production code
+(require 'music-config)
+
+;;; Normal Cases
+
+(ert-deftest test-music-config--safe-filename-normal-alphanumeric-unchanged ()
+  "Validate alphanumeric filename remains unchanged."
+  (should (string= (cj/music--safe-filename "MyPlaylist123")
+                   "MyPlaylist123")))
+
+(ert-deftest test-music-config--safe-filename-normal-with-hyphens-unchanged ()
+  "Validate filename with hyphens remains unchanged."
+  (should (string= (cj/music--safe-filename "my-playlist-name")
+                   "my-playlist-name")))
+
+(ert-deftest test-music-config--safe-filename-normal-with-underscores-unchanged ()
+  "Validate filename with underscores remains unchanged."
+  (should (string= (cj/music--safe-filename "my_playlist_name")
+                   "my_playlist_name")))
+
+(ert-deftest test-music-config--safe-filename-normal-spaces-replaced ()
+  "Validate spaces are replaced with underscores."
+  (should (string= (cj/music--safe-filename "My Favorite Songs")
+                   "My_Favorite_Songs")))
+
+;;; Boundary Cases
+
+(ert-deftest test-music-config--safe-filename-boundary-special-chars-replaced ()
+  "Validate special characters are replaced with underscores."
+  (should (string= (cj/music--safe-filename "playlist@#$%^&*()")
+                   "playlist_________")))
+
+(ert-deftest test-music-config--safe-filename-boundary-unicode-replaced ()
+  "Validate unicode characters are replaced with underscores."
+  (should (string= (cj/music--safe-filename "中文歌曲")
+                   "____")))
+
+(ert-deftest test-music-config--safe-filename-boundary-mixed-valid-invalid ()
+  "Validate mixed valid and invalid characters."
+  (should (string= (cj/music--safe-filename "Rock & Roll")
+                   "Rock___Roll")))
+
+(ert-deftest test-music-config--safe-filename-boundary-dots-replaced ()
+  "Validate dots are replaced with underscores."
+  (should (string= (cj/music--safe-filename "my.playlist.name")
+                   "my_playlist_name")))
+
+(ert-deftest test-music-config--safe-filename-boundary-slashes-replaced ()
+  "Validate slashes are replaced with underscores."
+  (should (string= (cj/music--safe-filename "folder/file")
+                   "folder_file")))
+
+(ert-deftest test-music-config--safe-filename-boundary-consecutive-invalid-chars ()
+  "Validate consecutive invalid characters each become underscores."
+  (should (string= (cj/music--safe-filename "test!!!name")
+                   "test___name")))
+
+(ert-deftest test-music-config--safe-filename-boundary-empty-string-unchanged ()
+  "Validate empty string remains unchanged."
+  (should (string= (cj/music--safe-filename "")
+                   "")))
+
+(ert-deftest test-music-config--safe-filename-boundary-only-invalid-chars ()
+  "Validate string with only invalid characters becomes all underscores."
+  (should (string= (cj/music--safe-filename "!@#$%")
+                   "_____")))
+
+;;; Error Cases
+
+(ert-deftest test-music-config--safe-filename-error-nil-input-signals-error ()
+  "Validate nil input signals error."
+  (should-error (cj/music--safe-filename nil)
+                :type 'wrong-type-argument))
+
+(provide 'test-music-config--safe-filename)
+;;; test-music-config--safe-filename.el ends here
-- 
cgit v1.2.3