From 58ef63abd5a9187ee93609f142cb21a933da16c5 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Thu, 26 Feb 2026 17:08:19 -0600 Subject: feat(recording): validate system audio device before recording Add pre-recording validation that catches stale or drifted system audio devices before they cause silent recordings. When the default audio output changes (Bluetooth reconnect, device switch) between setup and recording, the monitor device is auto-updated. Warns if no audio is currently playing through the monitored sink. Co-Authored-By: Craig Jennings --- tests/test-video-audio-recording-get-devices.el | 26 +++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) (limited to 'tests/test-video-audio-recording-get-devices.el') diff --git a/tests/test-video-audio-recording-get-devices.el b/tests/test-video-audio-recording-get-devices.el index 0af02bb3..66adecd1 100644 --- a/tests/test-video-audio-recording-get-devices.el +++ b/tests/test-video-audio-recording-get-devices.el @@ -39,10 +39,12 @@ (progn (setq cj/recording-mic-device "preset-mic") (setq cj/recording-system-device "preset-monitor") - (let ((result (cj/recording-get-devices))) - (should (consp result)) - (should (equal "preset-mic" (car result))) - (should (equal "preset-monitor" (cdr result))))) + (cl-letf (((symbol-function 'cj/recording--validate-system-audio) + (lambda () nil))) + (let ((result (cj/recording-get-devices))) + (should (consp result)) + (should (equal "preset-mic" (car result))) + (should (equal "preset-monitor" (cdr result)))))) (test-get-devices-teardown))) (ert-deftest test-video-audio-recording-get-devices-normal-calls-quick-setup () @@ -54,7 +56,9 @@ (lambda () (setq quick-setup-called t) (setq cj/recording-mic-device "quick-mic") - (setq cj/recording-system-device "quick-monitor")))) + (setq cj/recording-system-device "quick-monitor"))) + ((symbol-function 'cj/recording--validate-system-audio) + (lambda () nil))) (cj/recording-get-devices) (should quick-setup-called))) (test-get-devices-teardown))) @@ -66,7 +70,9 @@ (cl-letf (((symbol-function 'cj/recording-quick-setup) (lambda () (setq cj/recording-mic-device "test-mic") - (setq cj/recording-system-device "test-monitor")))) + (setq cj/recording-system-device "test-monitor"))) + ((symbol-function 'cj/recording--validate-system-audio) + (lambda () nil))) (let ((result (cj/recording-get-devices))) (should (consp result)) (should (equal "test-mic" (car result))) @@ -87,7 +93,9 @@ (lambda () (setq quick-setup-called t) (setq cj/recording-mic-device "new-mic") - (setq cj/recording-system-device "new-monitor")))) + (setq cj/recording-system-device "new-monitor"))) + ((symbol-function 'cj/recording--validate-system-audio) + (lambda () nil))) (cj/recording-get-devices) (should quick-setup-called)))) (test-get-devices-teardown))) @@ -104,7 +112,9 @@ (lambda () (setq quick-setup-called t) (setq cj/recording-mic-device "new-mic") - (setq cj/recording-system-device "new-monitor")))) + (setq cj/recording-system-device "new-monitor"))) + ((symbol-function 'cj/recording--validate-system-audio) + (lambda () nil))) (cj/recording-get-devices) (should quick-setup-called)))) (test-get-devices-teardown))) -- cgit v1.2.3