dotemacs/tests/test-custom-comments-comment-padded-divider.el, branch main My Emacs configuration https://git.cjennings.net/dotemacs/atom?h=main 2026-05-16T07:48:18+00:00 refactor(custom-editing): five hygiene fixes from the module-by-module re-review 2026-05-16T07:48:18+00:00 Craig Jennings c@cjennings.net 2026-05-16T07:48:18+00:00 urn:sha1:a9a4d8c7148c115a242a7b35d16dd536f9c0c700 - Guard `cj/duplicate-line-or-region' when COMMENT is non-nil but the current mode has no `comment-start' (e.g. fundamental-mode). Previously the function silently produced malformed output via `comment-region'; now it signals a clear `user-error'. - Factor the `find-file' advice install in external-open.el into `cj/external-open-install-advice'. Same idempotent shape (remove-then-add) but the intent is named. - Add `cj/--validate-decoration-char' in custom-comments.el and wire it into all six divider / border / box helpers. Rejects multi-char strings, empty strings, and control characters like newline/tab that would corrupt subsequent `M-q' flows. Updated the five nil-decoration ERT tests from `:type 'wrong-type-argument' (the old crash signal from `string-to-char' on nil) to `:type 'user-error', since the validator produces a clear message instead of a deep crash. - Extract `cj/--require-spell-checker' in flyspell-and-abbrev.el. Both `cj/flyspell-toggle' and `cj/flyspell-then-abbrev' now call the shared helper; the checker list lives in `cj/--spell-checker-executables', so adding nuspell or any other checker is a one-line edit. - Preserve trailing newlines in custom-ordering output. Both `cj/--arrayify' and `cj/--unarrayify' now detect a trailing newline on the input region and re-append it to the result, matching the pattern custom-text-enclose.el already uses. Revert "checking in modified/removed tests and other misc changes" 2025-11-14T08:35:00+00:00 Craig Jennings c@cjennings.net 2025-11-14T08:35:00+00:00 urn:sha1:2312e40358a923fe72785af504c9272506d8d58d This reverts commit 1218bae708a6755e3628f15fef58e6806ac81039. checking in modified/removed tests and other misc changes 2025-11-14T08:31:16+00:00 Craig Jennings c@cjennings.net 2025-11-14T08:31:16+00:00 urn:sha1:1218bae708a6755e3628f15fef58e6806ac81039 feat+test:comments: add 7 comment generation functions and tests 2025-10-27T01:25:59+00:00 Craig Jennings c@cjennings.net 2025-10-27T01:25:59+00:00 urn:sha1:0c6cd8584da8861727cbdb170fd654a8ac738671 Implement 5 new comment styles (simple-divider, padded-divider, heavy-box, unicode-box, block-banner) and refactor 2 existing functions (inline-border, comment-box) to use interactive/non-interactive pattern for testability. Add 178 tests across 7 test files with validation for length constraints and cross-language support. Fix linter warnings for parameter shadowing and docstring formatting.