dotemacs/tests/test-external-open-command.el, branch load-graph-classify-startMy Emacs configuration
https://git.cjennings.net/dotemacs/atom?h=load-graph-classify-start2026-05-10T20:37:36+00:00refactor(external-open): extract external-open-lib for shared helpers2026-05-10T20:37:36+00:00Craig Jenningsc@cjennings.net2026-05-10T20:37:36+00:00urn:sha1:618bc7813b9acfcf1dfccc9c6590f6f5aece86cf
Same shared-helpers split-pattern that ai-vterm/vterm-config use
through cj-window-toggle-lib and that calendar-sync uses through
cj-org-text-lib. Pull the two pure dispatch helpers out of the
external-open feature module into a sibling library so consumers
that only need the dispatch don't have to require the whole feature.
New `modules/external-open-lib.el' carries:
- `cj/external-open-command'
- `cj/external-open-launcher-p'
`modules/external-open.el' stays as the feature module: the
`default-open-extensions' defcustom, the `find-file' advice
(`cj/find-file-auto'), and the interactive commands (`cj/xdg-open',
`cj/open-this-file-with'). It now requires external-open-lib for
the dispatch helpers.
Migrate consumers:
- system-utils.el used to require `external-open' for
`cj/external-open-launcher-p' alone -- now requires
`external-open-lib' directly.
- dirvish-config.el calls `cj/external-open-command' from
`cj/dirvish-open-file-manager-here' -- add an explicit
`(require \='external-open-lib)'.
Test files renamed to match the system-lib naming pattern
(test-<library>-<feature>.el):
- test-external-open-command.el -> test-external-open-lib-command.el
- test-external-open-launcher-p.el -> test-external-open-lib-launcher-p.el
No behavior change.
refactor(external-open): consolidate OS-open dispatch in external-open.el2026-05-10T19:42:04+00:00Craig Jenningsc@cjennings.net2026-05-10T19:42:04+00:00urn:sha1:16396d25c2795bd7f8822a695de111d07f588b26
Phase 4 of utility-consolidation. Three previously-overlapping helpers (system-utils' `cj/identify-external-open-command' and `cj/--open-with-is-launcher-p', plus the dirvish-only `cj/--file-manager-program-for' shipped earlier today) all answered "which OS-open program should I run?". Pull the answer into one place: external-open.el.
Move and rename:
- `cj/--open-with-is-launcher-p' (system-utils) -> `cj/external-open-launcher-p' (external-open). Public name now matches its module.
- `cj/identify-external-open-command' (system-utils) -> `cj/external-open-command' (external-open). Returns nil for unsupported hosts instead of signaling -- callers that need a command must handle nil explicitly. The wrapper `cj/xdg-open' (also moved into external-open) converts nil to a `user-error' with a clear message, preserving the user-facing failure shape.
- Delete dirvish's `cj/--file-manager-program-for' helper. `cj/dirvish-open-file-manager-here' now calls `cj/external-open-command' directly. The shell-command fallback for nil-program preserves the previous escape hatch.
Break the system-utils <-> external-open recursive require by moving `cj/xdg-open' (the only system-utils function that external-open used) into external-open along with the dispatch.
Tests reorganized to match the move. Two new test files (`test-external-open-command.el', `test-external-open-launcher-p.el') replace the two system-utils-named test files. The dirvish file-manager-program test goes away with the helper. 11 tests covering Normal/Boundary/Error for the dispatch (plus the new "unsupported host returns nil" contract).
Add `(require \='external-open)' to system-utils.el and `(require \='system-lib)' to external-open.el (for `cj/file-from-context' which xdg-open uses).