dotemacs/tests/test-slack-config-reactions.el, branch load-graph-classify-startMy Emacs configuration
https://git.cjennings.net/dotemacs/atom?h=load-graph-classify-start2026-05-12T05:42:52+00:00fix(slack): error when adding a reaction outside a Slack buffer2026-05-12T05:42:52+00:00Craig Jenningsc@cjennings.net2026-05-12T05:42:52+00:00urn:sha1:8cb30ef6efd06464ab1153b99261a3f626149f97
`cj/slack-message-add-reaction' wrapped its whole body in `when-let*' on `slack-current-buffer', so invoking C-; S ! outside a Slack message view did nothing at all, and with no message it looked like the key wasn't even bound. It now `user-error's "Not in a Slack buffer". A test covers the case.
fix(slack): harden and curate the C-; S ! reaction workflow2026-05-11T22:17:54+00:00Craig Jenningsc@cjennings.net2026-05-11T22:17:54+00:00urn:sha1:bbd1b73cbaf1716734b1193467564a0c7122dec7
Two problems with `C-; S !'. First, emacs-slack's `slack-reaction-echo-description' runs in a buffer-local `post-command-hook' and can error on every keystroke when a reaction widget's text properties are malformed, which makes it hard to leave the Slack buffer or recover with C-g. It's now wrapped in `condition-case' that, on error, removes the hook from that buffer's local `post-command-hook' and messages once. Second, without emojify the upstream reaction picker is a flat completing-read over 1600+ names. `cj/slack-message-add-reaction' now offers a curated common list (`thumbsup', `pray', `eyes', `white_check_mark', `heart', `joy', `thinking_face', `rocket', `tada') with "Other..." delegating back to `slack-message-reaction-input' for the full set. Tests cover the hook hardening, the curated picker, and the `C-; S !' rebinding.