diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-23 03:35:32 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-23 03:35:32 -0500 |
| commit | 2047307de173044e46977528fe160cad2be7ff0b (patch) | |
| tree | e2cf386aac8b7783a2dad3a626aa8e561d6e8287 | |
| parent | 1f56dc065c1d9d725e4719c4576183d012b2b4b8 (diff) | |
| download | dotemacs-2047307de173044e46977528fe160cad2be7ff0b.tar.gz dotemacs-2047307de173044e46977528fe160cad2be7ff0b.zip | |
docs(todo): close host-env predicate cleanup
| -rw-r--r-- | todo.org | 19 |
1 files changed, 3 insertions, 16 deletions
@@ -1299,23 +1299,10 @@ Expected outcome: - Optional path failures should be logged but not block startup. - Add tests around success, optional failure, and required failure behavior. -**** TODO [#B] Clean up host environment predicates and timezone detection :cleanup:refactor:solo: - -Small module-specific cleanup in =host-environment.el=: -- =env-desktop-p= has a docstring that says "host is a laptop"; it should say - desktop / no battery. -- =env-x-p= uses =(string= (window-system) "x")= while =env-x11-p= uses symbol - comparison. Existing tests pass, but the two predicates should use one style - and document the difference between "X display" and "X11 not Wayland". -- =cj/match-localtime-to-zoneinfo= reads every zoneinfo file and compares - contents. That is fine as a fallback, but it is expensive enough to consider - caching or preferring symlink/env methods first if this ever runs during - startup. +**** 2026-05-23 Sat @ 03:33:30 -0500 Fixed env-desktop-p doc and normalized the X predicates +Corrected =env-desktop-p='s docstring (it described a laptop; the function returns t for the desktop/no-battery case). Switched =env-x-p= from =(string= (window-system) "x")= to =(eq (window-system) 'x)= to match =env-x11-p='s style, and documented the difference: =env-x-p= is any X display incl. XWayland, =env-x11-p= is a real X11 session with no WAYLAND_DISPLAY. Behavior unchanged, existing display-predicate tests stay green. Fixed in 14ec32b2. -Acceptance criteria: -- Fix the docstring. -- Normalize or document =env-x-p= vs =env-x11-p= semantics. -- Add or adjust tests only if behavior changes. +Left =cj/match-localtime-to-zoneinfo= caching alone — it was a "consider if this runs during startup" note, not an acceptance item, and it doesn't run at startup. File a separate task if it ever shows up in a profile. **** TODO [#B] Add minimal =system-defaults.el= setting smoke tests :tests: |