diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-10 13:41:27 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-10 13:41:27 -0500 |
| commit | ded114e36eef635ca8b65c77579a80f4e491edf6 (patch) | |
| tree | 31a3ceccf5cb58739dc62fa27135db78f42ccc2b /docs | |
| parent | f9306c0d9c8b3723e158cba9f07a60ae1352eb28 (diff) | |
| download | dotemacs-ded114e36eef635ca8b65c77579a80f4e491edf6.tar.gz dotemacs-ded114e36eef635ca8b65c77579a80f4e491edf6.zip | |
refactor(dirvish): extract cj/--ediff-pair-from-files; fix 0-files crash
`cj/dired-ediff-files' had its pair-determination logic inline: count check, prompt fallback when only one file was marked, and the older-first ordering for `ediff-files'. Lift it into `cj/--ediff-pair-from-files' -- pure given the file list, an injected prompt thunk, and a newer-than-p comparator -- so tests stay independent of mtimes and the dired prompt.
While extracting, surface a latent bug: with zero marked files the original code fell through to `(file-newer-than-file-p nil nil)' and crashed with a wrong-type-argument error. Replace the crash with a clear `user-error' ("No files marked"), and add a regression test. The 3+ files case keeps its existing user-error message.
Five Normal/Boundary/Error tests cover both ordering directions, the one-file prompt path, and both error counts.
Diffstat (limited to 'docs')
0 files changed, 0 insertions, 0 deletions