diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-03 21:34:05 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-03 21:34:05 -0500 |
| commit | a98aea92a73375f7344b64da826d8f0cca07694d (patch) | |
| tree | 0f4545bc0b14e2f6bdf8d0111f634cba45478c27 /modules/selection-framework.el | |
| parent | 1d58a3f547976ac46d673b99af8a4eedac52a92f (diff) | |
| download | dotemacs-a98aea92a73375f7344b64da826d8f0cca07694d.tar.gz dotemacs-a98aea92a73375f7344b64da826d8f0cca07694d.zip | |
refactor: drop dead intermediate C-s binding in selection-framework
`selection-framework.el` had two `keymap-global-set "C-s"` calls at module load. The first bound `C-s` to `consult-line`, then a later block rebound the same key to `cj/consult-line-or-repeat`. The second binding always won, so the first was dead configuration and made the file harder to reason about.
I removed the intermediate `consult-line` binding. The final `cj/consult-line-or-repeat` binding stays. Behavior is unchanged.
I added `tests/test-selection-framework-keybindings.el` with one smoke test: load the module with `use-package`, `consult-line`, and `vertico-repeat` stubbed, then assert `C-s` resolves to `cj/consult-line-or-repeat`. That locks in the cleanup so a future re-add of the dead binding would fail the test.
Diffstat (limited to 'modules/selection-framework.el')
| -rw-r--r-- | modules/selection-framework.el | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/modules/selection-framework.el b/modules/selection-framework.el index 5ace0a5f..1129ac05 100644 --- a/modules/selection-framework.el +++ b/modules/selection-framework.el @@ -127,9 +127,6 @@ ;; Use Consult for completion-at-point (setq completion-in-region-function #'consult-completion-in-region)) -;; Override default search with consult-line -(keymap-global-set "C-s" #'consult-line) - ;; Consult integration with Embark (use-package embark-consult :after (embark consult) |