diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-22 20:20:25 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-22 20:20:25 -0500 |
| commit | 5f8e1bc757fab620f5cf9b5fbc42b6a0030f5e53 (patch) | |
| tree | 93e27f408f5965b20099434170ee2d21ddd04bec /modules | |
| parent | 2c75893a6db2141099bc233f2b10dbb39cc5cf41 (diff) | |
| download | dotemacs-5f8e1bc757fab620f5cf9b5fbc42b6a0030f5e53.tar.gz dotemacs-5f8e1bc757fab620f5cf9b5fbc42b6a0030f5e53.zip | |
refactor(org): give org-log-done a single home
`org-log-done` was set in two places: `cj/org-todo-settings` in org-config.el set it nil, and org-roam-config.el's `:config` set it to 'time. Whichever module loaded last won, so the effective value was load-order-dependent and fragile.
I set it once in `cj/org-todo-settings` and dropped the org-roam-config setter, leaving a comment at the old site so it doesn't creep back. The value is 'time rather than nil because the dated-completion workflow wants a CLOSED timestamp stamped on every TODO->DONE.
Diffstat (limited to 'modules')
| -rw-r--r-- | modules/org-config.el | 2 | ||||
| -rw-r--r-- | modules/org-roam-config.el | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/modules/org-config.el b/modules/org-config.el index 31ed7f6c..bd51828a 100644 --- a/modules/org-config.el +++ b/modules/org-config.el @@ -117,7 +117,7 @@ (setq org-deadline-warning-days 7) ;; warn me w/in a week of deadlines (setq org-treat-insert-todo-heading-as-state-change nil) ;; log task creation (setq org-log-into-drawer nil) ;; don't log into drawer - (setq org-log-done nil) ;; don't log completions + (setq org-log-done 'time) ;; record a CLOSED timestamp on TODO->DONE ;; inherit parents properties (sadly not schedules or deadlines) (setq org-use-property-inheritance t)) diff --git a/modules/org-roam-config.el b/modules/org-roam-config.el index 0382976b..da4b0657 100644 --- a/modules/org-roam-config.el +++ b/modules/org-roam-config.el @@ -61,7 +61,7 @@ :map org-mode-map ("C-M-i" . completion-at-point)) :config - (setq org-log-done 'time) + ;; org-log-done is set once in org-config.el (cj/org-todo-settings). (setq org-agenda-timegrid-use-ampm t) (when (fboundp 'cj/build-org-refile-targets) |