diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-12 00:35:20 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-12 00:35:20 -0500 |
| commit | 30b06a9b289b08c93498acce4a70bc114f7d9093 (patch) | |
| tree | 20093f4a54c2c827a2f17d91395ca7ee0063791b /modules | |
| parent | ad9bf6afdd5abee9cb9ea0053a900a9482d374f2 (diff) | |
| download | dotemacs-30b06a9b289b08c93498acce4a70bc114f7d9093.tar.gz dotemacs-30b06a9b289b08c93498acce4a70bc114f7d9093.zip | |
refactor(mail): fail fast on an attachment part with no MIME handle
`cj/mu4e--save-attachment-part' called `cj/mu4e--ensure-attachment-save-functions' first, so a part with no MIME handle triggered the `mu4e-mime-parts' load before the handle check could fail. The handle check now runs first, so the malformed input is caught right away and the user-error fires the same way whether or not mu4e's MIME support is loadable. The test for that case drops the mu4e stubs it only needed because the load used to come first.
Diffstat (limited to 'modules')
| -rw-r--r-- | modules/mu4e-attachments.el | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/mu4e-attachments.el b/modules/mu4e-attachments.el index 87392681..8f711000 100644 --- a/modules/mu4e-attachments.el +++ b/modules/mu4e-attachments.el @@ -87,11 +87,11 @@ The result is an alist of display labels to MIME part plists." (defun cj/mu4e--save-attachment-part (part directory) "Save attachment PART to DIRECTORY and return the final path." - (cj/mu4e--ensure-attachment-save-functions) (let ((handle (plist-get part :handle))) (unless handle (user-error "Attachment has no MIME handle: %s" (or (plist-get part :filename) "<unnamed>"))) + (cj/mu4e--ensure-attachment-save-functions) (let* ((path (funcall mu4e-uniquify-save-file-name-function (mu4e-join-paths directory (plist-get part :filename))))) |