diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-10 13:15:48 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-10 13:15:48 -0500 |
| commit | f2c45a7146568bea7eea12270688c8c8ed814c86 (patch) | |
| tree | 866d32ca0484dea1d9414184988e2ae617ed0e16 /modules | |
| parent | 5eccbf7bd3c9780eee6170839dbf3224a32e9ef3 (diff) | |
| download | dotemacs-f2c45a7146568bea7eea12270688c8c8ed814c86.tar.gz dotemacs-f2c45a7146568bea7eea12270688c8c8ed814c86.zip | |
fix(dirvish): rename pw -> wp to clear quick-access key collision
Pressing `g' in dirvish (`dirvish-quick-access') failed with `Wrong type argument: command, (keymap (107 . transient:dirvish-quick-access::N))'. Transient auto-groups multi-character keys into nested prefix keymaps; when one entry's KEY is also the prefix of a longer entry's KEY, the shorter slot resolves to the auto-generated sub-prefix keymap rather than to the intended leaf command. The "wallpaper" entry on `pw' and the "project work" entry on `pwk' (added in 4ece1eb) collided. Rename `pw' to `wp'; `pwk' is now the only entry under the `pw'-prefix, so transient builds a clean leaf.
Add `tests/test-dirvish-config-quick-access.el' with five tests: four cover a small `test-dirvish-config--key-collisions' helper against synthetic inputs (collision detected, clean list, empty, single-entry), and one regression test asserts the live `dirvish-quick-access-entries' contains no shorter-key-is-prefix-of-longer-key pair.
Diffstat (limited to 'modules')
| -rw-r--r-- | modules/dirvish-config.el | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/dirvish-config.el b/modules/dirvish-config.el index 5f30ba10..fadf09ca 100644 --- a/modules/dirvish-config.el +++ b/modules/dirvish-config.el @@ -268,8 +268,8 @@ Uses feh on X11, swww on Wayland." ("pk" "~/projects/kit/" "project kit") ("pn" "~/projects/nextjob/" "project nextjob") ("ps" ,(concat pix-dir "/screenshots/") "pictures screenshots") - ("pw" ,(concat pix-dir "/wallpaper/") "pictures wallpaper") ("px" ,pix-dir "pictures directory") + ("wp" ,(concat pix-dir "/wallpaper/") "pictures wallpaper") ("rcj" "/sshx:cjennings@cjennings.net:~" "remote c@cjennings.net") ("rtl" "/sshx:cjennings@truenas.local:~" "remote cjennings@truenas.local") ("rtt" "/sshx:cjennings@truenas:~" "remote cjennings@truenas (tailscale)") |