diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-12 00:40:22 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-12 00:40:22 -0500 |
| commit | ab177c8178e05bd8238fa80ee4c705d3a00c67f7 (patch) | |
| tree | d5e2e06ffdd54a44a68b573c483562972a669b64 /tests | |
| parent | 30b06a9b289b08c93498acce4a70bc114f7d9093 (diff) | |
| download | dotemacs-ab177c8178e05bd8238fa80ee4c705d3a00c67f7.tar.gz dotemacs-ab177c8178e05bd8238fa80ee4c705d3a00c67f7.zip | |
refactor(lsp): rename cj/lsp--disable-eldoc-hover for accuracy
The helper removes lsp-mode's entry from `eldoc-documentation-functions' in the current buffer. It never touched hover display, so the old name was misleading. It's now `cj/lsp--remove-eldoc-provider', the two tests rename to match, and the docstring drops the "hover" wording.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test-prog-lsp--add-file-watch-ignored-extras.el | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/tests/test-prog-lsp--add-file-watch-ignored-extras.el b/tests/test-prog-lsp--add-file-watch-ignored-extras.el index 6213b58c..142cd2ea 100644 --- a/tests/test-prog-lsp--add-file-watch-ignored-extras.el +++ b/tests/test-prog-lsp--add-file-watch-ignored-extras.el @@ -87,21 +87,21 @@ (should-error (cj/lsp--add-file-watch-ignored-extras) :type 'wrong-type-argument))) -(ert-deftest test-prog-lsp--disable-eldoc-hover-removes-lsp-provider-locally () +(ert-deftest test-prog-lsp--remove-eldoc-provider-removes-lsp-provider-locally () "Normal: remove lsp-mode's Eldoc provider from the buffer-local hook." (with-temp-buffer (setq-local eldoc-documentation-functions '(lsp-eldoc-function eldoc-documentation-default)) - (cj/lsp--disable-eldoc-hover) + (cj/lsp--remove-eldoc-provider) (should-not (memq #'lsp-eldoc-function eldoc-documentation-functions)) (should (memq 'eldoc-documentation-default eldoc-documentation-functions)))) -(ert-deftest test-prog-lsp--disable-eldoc-hover-does-not-touch-default-value () - "Boundary: disabling LSP Eldoc in one buffer leaves the default hook alone." +(ert-deftest test-prog-lsp--remove-eldoc-provider-does-not-touch-default-value () + "Boundary: removing the LSP provider in one buffer leaves the default hook alone." (let ((eldoc-documentation-functions '(lsp-eldoc-function))) (with-temp-buffer (setq-local eldoc-documentation-functions '(lsp-eldoc-function)) - (cj/lsp--disable-eldoc-hover) + (cj/lsp--remove-eldoc-provider) (should-not (memq #'lsp-eldoc-function eldoc-documentation-functions))) (should (memq #'lsp-eldoc-function eldoc-documentation-functions)))) |