diff options
| -rw-r--r-- | todo.org | 13 |
1 files changed, 3 insertions, 10 deletions
@@ -1653,16 +1653,9 @@ stays warm with the old VC backend. Add the resolved =file-truename= to the key, or invalidate the cache when =vc-backend= disagrees with the cached entry. -**** TODO [#B] Move =C-s= binding into =consult= =:bind= for =isearch-mode-map= :safety:solo: - -=modules/selection-framework.el:253= binds =C-s= globally to -=cj/consult-line-or-repeat=. The same module's =consult= =:bind= -block rebinds =M-s e= in =isearch-mode-map=. Once isearch is active, -pressing =C-s= should advance to the next match -- isearch's own -keymap convention -- but the global binding shadows that and exits -isearch into consult-line. Move the =C-s= binding into the consult -=:bind= block under =:map isearch-mode-map= to preserve isearch's -in-mode contract. +**** 2026-05-24 Sun @ 04:01:02 -0500 Verified C-s already advances isearch — non-bug, no change + +The premise didn't hold on Emacs 30.2. Investigated in the live daemon: while isearch is active, =overriding-terminal-local-map= is =isearch-mode-map= and the effective =C-s= resolves to =isearch-repeat-forward=, not =cj/consult-line-or-repeat=. isearch installs its own map as an overriding map, so the global =C-s= binding can't shadow it during a search. =isearch-mode-map= already binds =C-s= to =isearch-repeat-forward= by default. Adding an explicit binding to the consult =:bind= block would only duplicate that default, so I left =selection-framework.el= unchanged. **** 2026-05-16 Sat @ 02:55:14 -0500 Guarded cursor-color hook behind display-graphic-p (with daemon-mode catch) |