From a4add68ff8a4d84034f0412acd30b3494a24acad Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Mon, 15 Jun 2026 13:58:04 -0500 Subject: feat(face-diagnostic): bind cj/describe-face-at-point to C-h F Bind the diagnostic in the help cluster on C-h F (Face), Craig's pick. It shadows helpful-function, which also sits on C-h F in this config. face-diagnostic is required after help-config, so this binding wins. A test asserts C-h F resolves to the command. --- modules/face-diagnostic.el | 7 ++++++- tests/test-face-diagnostic.el | 6 ++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/modules/face-diagnostic.el b/modules/face-diagnostic.el index 83c81d92c..6b1b547f1 100644 --- a/modules/face-diagnostic.el +++ b/modules/face-diagnostic.el @@ -8,7 +8,7 @@ ;; Load shape: eager. ;; Eager reason: none; a diagnostic command, a command-loaded deferral candidate. ;; Top-level side effects: defines cj/face-diagnostic-mode and the -;; cj/describe-face-at-point command; binds no global key. +;; cj/describe-face-at-point command; binds it to C-h F in help-map. ;; Runtime requires: seq. ;; Direct test load: yes (the pure core is tested by requiring this module). ;; @@ -447,5 +447,10 @@ See docs/specs/face-font-diagnostic-popup-spec-implemented.org." (cj/--face-diag-render-region (region-beginning) (region-end)) (cj/--face-diag-render (cj/--face-diagnosis-at (point)))))) +;; Bound on C-h F (Face) in the help cluster. This shadows helpful-function, +;; which also sits on C-h F here; face-diagnostic loads after help-config, so +;; this binding wins. +(keymap-set help-map "F" #'cj/describe-face-at-point) + (provide 'face-diagnostic) ;;; face-diagnostic.el ends here diff --git a/tests/test-face-diagnostic.el b/tests/test-face-diagnostic.el index f75d5b679..241425fc5 100644 --- a/tests/test-face-diagnostic.el +++ b/tests/test-face-diagnostic.el @@ -322,5 +322,11 @@ (should (string-match-p "Face stack" (buffer-string))))) (when (buffer-live-p buf) (kill-buffer buf)))))) +;;; keybinding + +(ert-deftest test-face-diag-bound-on-c-h-F () + "Normal: loading the module binds C-h F to the diagnostic command." + (should (eq (keymap-lookup help-map "F") 'cj/describe-face-at-point))) + (provide 'test-face-diagnostic) ;;; test-face-diagnostic.el ends here -- cgit v1.2.3