From fcf6eac37934c3e2d1dbe68776c967ad9194c0ac Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Mon, 15 Jun 2026 23:23:20 -0500 Subject: fix(vertico): Page-Up/Down scroll the candidate list, not history / weren't bound in vertico-map, so in a long completing-read they fell through and selected-then-dismissed the list. Bind them to vertico-scroll-up / vertico-scroll-down. --- modules/selection-framework.el | 18 +++++++++++------- todo.org | 4 +++- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/modules/selection-framework.el b/modules/selection-framework.el index b136ad154..a567e8003 100644 --- a/modules/selection-framework.el +++ b/modules/selection-framework.el @@ -37,13 +37,17 @@ (vertico-resize nil) ; Don't resize the minibuffer (vertico-sort-function #'vertico-sort-history-alpha) ; History first, then alphabetical :bind (:map vertico-map - ("C-j" . vertico-next) - ("C-k" . vertico-previous) - ("C-l" . vertico-insert) ; Insert current candidate - ("RET" . vertico-exit) - ("C-RET" . vertico-exit-input) - ("M-RET" . minibuffer-force-complete-and-exit) - ("TAB" . minibuffer-complete)) + ("C-j" . vertico-next) + ("C-k" . vertico-previous) + ("C-l" . vertico-insert) ; Insert current candidate + ("RET" . vertico-exit) + ("C-RET" . vertico-exit-input) + ("M-RET" . minibuffer-force-complete-and-exit) + ("TAB" . minibuffer-complete) + ;; Page-Up/Down scroll the candidate page instead of falling + ;; through to minibuffer history (which selected + dismissed). + ("" . vertico-scroll-up) + ("" . vertico-scroll-down)) :init (vertico-mode)) diff --git a/todo.org b/todo.org index de07399f5..5b138f85c 100644 --- a/todo.org +++ b/todo.org @@ -4093,7 +4093,9 @@ The core functionality is implemented but needs debugging before it's production 3. Refine toggle behavior based on testing 4. Document the final keybindings and workflow -** TODO [#C] Page-down in a long completing-read selects and dismisses the list :bug:next: +** DONE [#C] Page-down in a long completing-read selects and dismisses the list :bug:next: +CLOSED: [2026-06-15 Mon] +Bound / to vertico-scroll-up/down in vertico-map, so Page-Up/Down page the candidate list instead of falling through to history (which selected and dismissed). Verified live (use-package :bind isn't reachable under make test). In a very long completing-read (vertico), Page-Down selects an item and the list vanishes instead of paging, forcing a cancel. Investigate the completion stack's next-page handling; likely needs vertico-scroll-up / vertico-scroll-down bound in vertico-map. From the roam inbox. ** VERIFY [#C] page-signal pager account deregistered — re-registration needs your hands :PROPERTIES: -- cgit v1.2.3