From 13b053c2a99d30c1131d920a62febde6ee9a628b Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 2 Jun 2026 20:38:06 -0500 Subject: feat(ui): name the operation in completing-read prompts A picker prompt is the last thing shown before a command commits, so a bare noun leaves a mis-keyed command ambiguous. Hitting C-f8 (project agenda) instead of C-f9 (AI-vterm picker) gave the same "Project:" prompt with no signal which one was about to run. Reworded 17 prompts across 8 modules so each names the operation rather than just the thing being chosen: "Project:" becomes "Show agenda for project:", "F6:" becomes "Run tests:", the dwim-shell sub-prompts gain their context (checksum algorithm, PDF compression quality, text-to-speech voice, run dwim-shell command), the two contact pickers split into "Find contact:" and "Insert contact email:", and the dirvish ediff, org finalize, and custom-comments length/box-style prompts get the same treatment. I audited all ~124 completing-read / read-* call sites; the rest already named their operation and were left alone. These are prompt-string changes only, no logic touched. --- modules/custom-comments.el | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'modules/custom-comments.el') diff --git a/modules/custom-comments.el b/modules/custom-comments.el index 4e203f12..b6919d65 100644 --- a/modules/custom-comments.el +++ b/modules/custom-comments.el @@ -236,7 +236,7 @@ Prompts for decoration character, text, and length option." "")) (decoration-char (read-string "Decoration character (default =): " nil nil "=")) (text (read-string "Comment text: ")) - (length-option (completing-read "Length: " + (length-option (completing-read "Comment length: " '("fill-column" "half-column" "match-text") nil t nil nil "fill-column")) (length (cond @@ -318,7 +318,7 @@ Prompts for decoration character, text, padding, and length option." (decoration-char (read-string "Decoration character (default =): " nil nil "=")) (text (read-string "Comment text: ")) (padding (string-to-number (read-string "Padding spaces (default 2): " nil nil "2"))) - (length-option (completing-read "Length: " + (length-option (completing-read "Comment length: " '("fill-column" "half-column" "match-text") nil t nil nil "fill-column")) (length (cond @@ -463,7 +463,7 @@ Prompts for decoration character, text, and length option." "")) (decoration-char (read-string "Decoration character (default *): " nil nil "*")) (text (read-string "Comment text: ")) - (length-option (completing-read "Length: " + (length-option (completing-read "Comment length: " '("fill-column" "half-column" "padded-text") nil t nil nil "fill-column")) (length (cond @@ -545,10 +545,10 @@ Prompts for text, box style, and length option." comment-end "")) (text (read-string "Comment text: ")) - (box-style (intern (completing-read "Box style: " + (box-style (intern (completing-read "Comment box style: " '("single" "double") nil t nil nil "single"))) - (length-option (completing-read "Length: " + (length-option (completing-read "Comment length: " '("fill-column" "half-column" "padded-text") nil t nil nil "fill-column")) (length (cond @@ -611,7 +611,7 @@ Prompts for decoration character, text, and length option." (read-string "Block comment end (e.g., */): " nil nil "*/"))) (decoration-char (read-string "Decoration character (default *): " nil nil "*")) (text (read-string "Comment text: ")) - (length-option (completing-read "Length: " + (length-option (completing-read "Comment length: " '("fill-column" "half-column" "match-text") nil t nil nil "fill-column")) (length (cond -- cgit v1.2.3