From d84aa4374af5e3447445377a836c66cc07d7a223 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Sat, 16 May 2026 03:55:49 -0500
Subject: refactor(prog): six programming-track hygiene fixes from re-review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- prog-lsp.el: rename `cj/lsp--remove-eldoc-provider' →
  `cj/lsp--remove-eldoc-provider-global' and call it once from the
  lsp-mode `:config' block instead of attaching it per-buffer via
  `lsp-managed-mode-hook'.  The previous per-buffer remove with the
  buffer-local flag raced lsp-mode's own population of the local
  hook; removing the provider from the global default before any LSP
  buffer attaches makes the absence stick.  Two existing tests
  updated to the new contract (remove-from-default + idempotent
  re-run).

- prog-webdev.el / prog-python.el: warn at load time when
  `prettier' or `pyright' is missing on PATH via
  `cj/executable-find-or-warn'.  Both modules now `(require
  'system-lib)' to expose the helper.  Missing dependencies surface
  up front instead of mid-edit at first format/LSP attach.

- keyboard-compat.el: document existing idempotence.  The hook
  install uses a named function so `add-hook' deduplicates, and the
  hook body only calls `define-key' (latest binding wins, same
  value) -- adding a comment so future readers don't re-question.

- dev-fkeys.el: add a `typescript' clause to
  `cj/--f6-test-runner-cmd-for'.  F6 now runs `npx --no-install
  vitest <path>' when vitest is on PATH, otherwise `npx --no-install
  jest <path>'.  Updates the matching test from "returns nil" to
  cover both code paths; the impl-level test now asserts the routed
  command instead of expecting a user-error.

- flycheck-config.el: build the LanguageTool wrapper path with
  `(expand-file-name "scripts/languagetool-flycheck"
  user-emacs-directory)' instead of a hardcoded `~/.emacs.d/...'.
  Survives a non-standard `user-emacs-directory'.

- latex-config.el: replace the hardcoded Zathura viewer with
  `cj/--latex-select-pdf-viewer', which walks
  `cj/--latex-pdf-viewer-candidates' (zathura → evince → okular →
  SumatraPDF → xdg-open) and falls back to "PDF Tools" when nothing
  is on PATH.  Each entry maps an executable to the matching
  TeX-view-program-list name so AUCTeX's defaults handle the
  actual viewer invocation.
---
 modules/dev-fkeys.el | 9 +++++++++
 1 file changed, 9 insertions(+)

(limited to 'modules/dev-fkeys.el')

diff --git a/modules/dev-fkeys.el b/modules/dev-fkeys.el
index 170e70b9..3b0a818c 100644
--- a/modules/dev-fkeys.el
+++ b/modules/dev-fkeys.el
@@ -370,6 +370,15 @@ TypeScript / JavaScript and unknown languages return nil."
               (if (string-empty-p rel-dir)
                   "./"
                 (format "./%s" rel-dir)))))
+    ('typescript
+     ;; Prefer vitest when present on PATH, fall back to jest otherwise.
+     ;; Both runners take a path argument and accept relative paths.
+     (let ((runner (or (and (executable-find "vitest") "vitest")
+                       (and (executable-find "jest")   "jest")
+                       "jest")))  ; reasonable default for stack traces
+       (format "npx --no-install %s %s"
+               runner
+               (cj/shell-quote-argument-readable rel-path))))
     (_ nil)))
 
 ;; ---------- F6 current-file orchestrator ----------
-- 
cgit v1.2.3