From 2dd56761df8e6b6d7b5f99c5c7c6d20f5b2d6447 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Fri, 15 May 2026 23:00:59 -0500 Subject: fix(flycheck): correct abbrev-mode no-arg toggle in cj/prose-helpers-on The shape (if (not (abbrev-mode)) (abbrev-mode)) calls abbrev-mode with no argument -- that's the toggle signature, not a query. When the mode was already on the function flipped it off then on instead of being a no-op. Replaced with (unless (bound-and-true-p VAR) (MODE 1)) for both abbrev-mode and flycheck-mode. 4 ERT tests cover both-off, both-on, and the two mixed states. Also ran the module hardening pass across 24 newly-added modules, renamed the six completed Review sub-tasks to Harden, filed 11 new findings under their Harden parents, and broke three design specs (EMMS-free music, dev F-keys, dev-setup-project) into 20 dependency-ordered sub-tasks via parallel subagents. Verified the sqlite finalizer bug from 2026-04-26 is gone and closed its tracking entry. --- modules/flycheck-config.el | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'modules/flycheck-config.el') diff --git a/modules/flycheck-config.el b/modules/flycheck-config.el index e2e8abe9..8c3e2a7b 100644 --- a/modules/flycheck-config.el +++ b/modules/flycheck-config.el @@ -34,13 +34,12 @@ ;;; Code: (defun cj/prose-helpers-on () - "Ensure that abbrev, flyspell, and flycheck are all on." + "Ensure that `abbrev-mode' and `flycheck-mode' are on in the current buffer." (interactive) - (if (not (abbrev-mode)) - (abbrev-mode)) - ;; (flyspell-on-for-buffer-type) - (if (not (flycheck-mode)) - (flycheck-mode))) + (unless (bound-and-true-p abbrev-mode) + (abbrev-mode 1)) + (unless (bound-and-true-p flycheck-mode) + (flycheck-mode 1))) ;; ---------------------------------- Linting ---------------------------------- -- cgit v1.2.3