From adca2736e2e3ef1eef1aaf62542aa2189a560463 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sat, 16 May 2026 02:12:56 -0500 Subject: feat(modeline): surface flycheck status in the custom modeline MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The custom modeline builds `mode-line-format` from explicit segments and skips `minor-mode-alist`, so flycheck's lighter never appears. That hid error and warning counts even in buffers where flycheck was auto-enabling (every emacs-lisp and sh buffer). The fix is Option 4 from the design doc: customize the flycheck modeline variables, then add a single guarded `(:eval ...)` form to `mode-line-format`. Five new lines total, two-file change. `modules/flycheck-config.el` :custom block gets: (flycheck-mode-line-prefix "🐛") (flycheck-mode-success-indicator " ✓") `flycheck-mode-line-color` stays default-t so error / warning counts pick up their faces automatically. `modules/modeline-config.el` `mode-line-format` gets an `(:eval ...)` between the recording indicator and `cj/modeline-vc-branch`: (:eval (when (and (mode-line-window-selected-p) (bound-and-true-p flycheck-mode)) (flycheck-mode-line-status-text))) The `mode-line-window-selected-p` guard mirrors `cj/modeline-vc-branch` and `cj/modeline-misc-info` -- segments hide in inactive windows. The `bound-and-true-p flycheck-mode` guard keeps the form silent in buffers where flycheck hasn't loaded or isn't enabled, which is safer than referencing `flycheck-mode` directly. The `(:eval ...)` is inline rather than a named `defvar-local`, so no addition to the risky-local-variable list is needed. `tests/test-modeline-config-flycheck-segment.el` -- 3 smoke tests asserting the segment is present and both guards are in place. All existing tests stay green. Manual verification (per the design doc) is the user's call -- the emoji prefix and the colored count behavior need a running GUI Emacs to observe. --- modules/flycheck-config.el | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'modules/flycheck-config.el') diff --git a/modules/flycheck-config.el b/modules/flycheck-config.el index 8c3e2a7b..e6dfb25e 100644 --- a/modules/flycheck-config.el +++ b/modules/flycheck-config.el @@ -56,6 +56,11 @@ (checkdoc-arguments '(("sentence-end-double-space" nil) ("warn-escape" nil))) + ;; Modeline customization (rendered via mode-line-format in modeline-config.el). + ;; The count portion picks up `error' / `warning' faces because + ;; `flycheck-mode-line-color' stays t (the default). + (flycheck-mode-line-prefix "🐛") + (flycheck-mode-success-indicator " ✓") :config ;; use the load-path of the currently running Emacs instance -- cgit v1.2.3