From a005c7636f30b710e27a6812ca989506d5df7531 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sat, 16 May 2026 03:45:29 -0500 Subject: refactor(org-workflow): four hygiene fixes from the module-by-module re-review - org-roam-config.el: extract `cj/--org-roam-should-copy-completed-task-p' and gate the `org-after-todo-state-change-hook' on it. Skips fileless buffers (org-capture, indirect, temp Org) where `buffer-file-name' is nil and the downstream copy used to crash. Same gcal.org skip preserved. Five existing tests updated to bind `buffer-file-name' inside `run-hooks' so the positive-case hook still fires. - org-webclipper.el: drop the redundant `org-protocol-protocol-alist' registration inside `cj/webclipper-ensure-initialized'. The `with-eval-after-load 'org-protocol' block at the bottom of the module is the single registration site now; comment in the initializer explains why. Split the matching test into two: one for template registration (the initializer's actual job) and one for protocol registration (which now fires from the after-load block when `org-protocol' provides). - org-webclipper.el: validate `:url' and `:title' in `cj/org-protocol-webclip'. `:url' must be a non-empty string; `:title' must be a string when provided. Signals `user-error' with the unexpected value instead of silently setting the globals to nil and failing downstream in the capture handler. - mu4e-org-contacts-integration.el: declare `contacts-file' (via `eval-when-compile (defvar ...)') and `cj/get-all-contact-emails' (via `declare-function') near the top of the file. Byte-compile in isolation no longer warns about free variables / unknown functions; the cross-module dependency is explicit at the top. --- modules/mu4e-org-contacts-integration.el | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'modules/mu4e-org-contacts-integration.el') diff --git a/modules/mu4e-org-contacts-integration.el b/modules/mu4e-org-contacts-integration.el index 8ffdccd2d..68f83dd21 100644 --- a/modules/mu4e-org-contacts-integration.el +++ b/modules/mu4e-org-contacts-integration.el @@ -13,6 +13,13 @@ (require 'mu4e nil t) (require 'org-contacts nil t) +;; Cross-module symbols this file references. Declared so byte-compile in +;; isolation doesn't warn about free variables / undefined functions; the +;; actual definitions live where named. +(eval-when-compile (defvar contacts-file)) ; user-constants.el +(declare-function cj/get-all-contact-emails ; org-contacts-config.el + "org-contacts-config" ()) + ;; ---------------------- Completion at Point Function ------------------------- (defun cj/org-contacts-completion-at-point () -- cgit v1.2.3