From 8cb30ef6efd06464ab1153b99261a3f626149f97 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 12 May 2026 00:42:52 -0500 Subject: fix(slack): error when adding a reaction outside a Slack buffer `cj/slack-message-add-reaction' wrapped its whole body in `when-let*' on `slack-current-buffer', so invoking C-; S ! outside a Slack message view did nothing at all, and with no message it looked like the key wasn't even bound. It now `user-error's "Not in a Slack buffer". A test covers the case. --- modules/slack-config.el | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'modules/slack-config.el') diff --git a/modules/slack-config.el b/modules/slack-config.el index 14d15ecf..3e9ae283 100644 --- a/modules/slack-config.el +++ b/modules/slack-config.el @@ -171,14 +171,14 @@ so the Slack buffer stays usable." reaction))) (defun cj/slack-message-add-reaction () - "Add a reaction to the current Slack message using a curated shortlist." + "Add a reaction to the current Slack message using a curated shortlist. +Errors if called outside a Slack message buffer." (interactive) - (when-let* ((buf slack-current-buffer) - (team (slack-buffer-team buf)) - (reaction (cj/slack-select-reaction team))) - (slack-buffer-add-reaction-to-message buf - reaction - (slack-get-ts)))) + (let ((buf (or slack-current-buffer + (user-error "Not in a Slack buffer")))) + (when-let* ((team (slack-buffer-team buf)) + (reaction (cj/slack-select-reaction team))) + (slack-buffer-add-reaction-to-message buf reaction (slack-get-ts))))) (with-eval-after-load 'slack-buffer (advice-add 'slack-reaction-echo-description -- cgit v1.2.3