From 1e59e346ab7e15c07e3b176cefaa92dbadb53c27 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Fri, 15 May 2026 02:31:53 -0500 Subject: refactor(org-webclipper): use setq, not setopt, for pandoc sleep time `org-web-tools-pandoc-sleep-time' is a plain float with no custom-set handler that needs to fire. `setopt' adds the entire customize-variable validation machinery -- which, lazily, depends on wid-edit being loaded. The handler's tests stub `require' so org-web-tools never really loads, then mock `setopt' via `cl-letf' on the function cell. That mock has no effect on byte-compiled code because `setopt' is a macro: the production handler has already expanded to a call into `setopt--set'. When `setopt--set' runs, it walks into the customize machinery and hits an unbound `widget-field-keymap' (wid-edit not loaded), and the test fails with a confusing wrong-type-argument. `setq' has identical runtime effect for this variable and dodges the customize machinery entirely. Tests now pass without contorted mocking. --- modules/org-webclipper.el | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'modules') diff --git a/modules/org-webclipper.el b/modules/org-webclipper.el index 7b024e43..be4c1cb6 100644 --- a/modules/org-webclipper.el +++ b/modules/org-webclipper.el @@ -135,9 +135,15 @@ INFO is a plist containing :url and :title from the org-protocol call." "Handle web page clipping during org-capture. This function is called from the capture template. It fetches the page content and converts it to Org format." - ;; Load org-web-tools only when actually needed + ;; Load org-web-tools only when actually needed. Use plain `setq' + ;; rather than `setopt' because the variable is a plain float with no + ;; custom-set handler that needs to fire, and `setopt' is a macro -- + ;; tests that try to stub it via `cl-letf' on the function cell hit + ;; the already-expanded `setopt--set' in the byte-compiled handler + ;; and fail with a `void-variable widget-field-keymap' error from + ;; the customize machinery loading lazily. (require 'org-web-tools) - (setopt org-web-tools-pandoc-sleep-time 0.5) + (setq org-web-tools-pandoc-sleep-time 0.5) (let ((url cj/webclip-current-url) (title cj/webclip-current-title)) -- cgit v1.2.3