From 266a660cb8db190e0418c5f7062af95e1a31270f Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Thu, 14 May 2026 07:18:11 -0500 Subject: fix(org-roam-config): save journal buffer after copying DONE task `cj/org-roam-copy-todo-to-today' tried to save the target journal buffer via `org-after-refile-insert-hook' bound to `#'save-buffer', but that value is the wrong shape (single function instead of a hook list), and the only other save mechanism -- the `:after' advice on `org-refile' that calls `org-save-all-org-buffers' -- doesn't attach until `:defer .5' elapses, so the very first DONE transition after startup leaves the journal unsaved. Drop the broken hook binding and save the target buffer explicitly after the refile call. New ERT test asserts `buffer-modified-p' on the journal buffer is nil after the function returns. --- modules/org-roam-config.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'modules') diff --git a/modules/org-roam-config.el b/modules/org-roam-config.el index 3f011c9d..52c41127 100644 --- a/modules/org-roam-config.el +++ b/modules/org-roam-config.el @@ -170,7 +170,6 @@ created in that subdirectory of `org-roam-directory'." :if-new (file+head+olp "%<%Y-%m-%d>.org" "#+FILETAGS: Journal #+TITLE: %<%Y-%m-%d>\n" ("Completed Tasks"))))) - (org-after-refile-insert-hook #'save-buffer) today-file pos) (save-window-excursion @@ -181,7 +180,11 @@ created in that subdirectory of `org-roam-directory'." ;; Only refile if the target file is different than the current file (unless (equal (file-truename today-file) (file-truename (buffer-file-name))) - (org-refile nil nil (list "Completed Tasks" today-file nil pos))))) + (org-refile nil nil (list "Completed Tasks" today-file nil pos)) + ;; Save explicitly so shutdown doesn't prompt about an unsaved journal buffer. + (when-let ((target-buffer (find-buffer-visiting today-file))) + (with-current-buffer target-buffer + (save-buffer)))))) ;; ------------------------ Org-Branch To Org-Roam-Node ------------------------ -- cgit v1.2.3