From b2d44d70374db0ab801d18f8c04d1b021396ea46 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sun, 3 May 2026 21:34:05 -0500 Subject: refactor: drop dead intermediate C-s binding in selection-framework `selection-framework.el` had two `keymap-global-set "C-s"` calls at module load. The first bound `C-s` to `consult-line`, then a later block rebound the same key to `cj/consult-line-or-repeat`. The second binding always won, so the first was dead configuration and made the file harder to reason about. I removed the intermediate `consult-line` binding. The final `cj/consult-line-or-repeat` binding stays. Behavior is unchanged. I added `tests/test-selection-framework-keybindings.el` with one smoke test: load the module with `use-package`, `consult-line`, and `vertico-repeat` stubbed, then assert `C-s` resolves to `cj/consult-line-or-repeat`. That locks in the cleanup so a future re-add of the dead binding would fail the test. --- modules/selection-framework.el | 3 --- 1 file changed, 3 deletions(-) (limited to 'modules') diff --git a/modules/selection-framework.el b/modules/selection-framework.el index 5ace0a5f..1129ac05 100644 --- a/modules/selection-framework.el +++ b/modules/selection-framework.el @@ -127,9 +127,6 @@ ;; Use Consult for completion-at-point (setq completion-in-region-function #'consult-completion-in-region)) -;; Override default search with consult-line -(keymap-global-set "C-s" #'consult-line) - ;; Consult integration with Embark (use-package embark-consult :after (embark consult) -- cgit v1.2.3