From b45638194cc19b026c49e0cb4787024c73723954 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 12 May 2026 00:40:22 -0500 Subject: refactor(lsp): rename cj/lsp--disable-eldoc-hover for accuracy The helper removes lsp-mode's entry from `eldoc-documentation-functions' in the current buffer. It never touched hover display, so the old name was misleading. It's now `cj/lsp--remove-eldoc-provider', the two tests rename to match, and the docstring drops the "hover" wording. --- modules/prog-lsp.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'modules') diff --git a/modules/prog-lsp.el b/modules/prog-lsp.el index 8e889678..e03a475d 100644 --- a/modules/prog-lsp.el +++ b/modules/prog-lsp.el @@ -48,8 +48,9 @@ Idempotent — `add-to-list' skips patterns already present." (dolist (pattern cj/lsp-file-watch-ignored-extras) (add-to-list 'lsp-file-watch-ignored-directories pattern))) -(defun cj/lsp--disable-eldoc-hover () - "Remove lsp-mode's Eldoc hover provider in the current buffer." +(defun cj/lsp--remove-eldoc-provider () + "Remove lsp-mode's provider from `eldoc-documentation-functions' here. +Buffer-local — the global hook value is untouched." (remove-hook 'eldoc-documentation-functions #'lsp-eldoc-function t)) ;;;;; ---------------------------- LSP Mode --------------------------- @@ -72,7 +73,7 @@ Idempotent — `add-to-list' skips patterns already present." (setq lsp-enable-on-type-formatting nil) (setq lsp-signature-auto-activate nil) (setq lsp-signature-render-documentation nil) - (add-hook 'lsp-managed-mode-hook #'cj/lsp--disable-eldoc-hover) + (add-hook 'lsp-managed-mode-hook #'cj/lsp--remove-eldoc-provider) (setq lsp-modeline-code-actions-enable nil) (setq lsp-modeline-diagnostics-enable nil) (setq lsp-headerline-breadcrumb-enable nil) -- cgit v1.2.3