From 64153c8d995f1603986f3b44ccbdf9ddb21dfd55 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Thu, 18 Jun 2026 21:42:40 -0500
Subject: feat(theme-studio): widen the face model with the additive attributes

This is Phase 2 of the face-attribute expansion. The model now carries distant-fg, family, overline, inverse, and extend in final shape across all three tiers, and inherit and height are no longer package-only (a ui or syntax face can set them too).

I kept bold/italic/underline/strike as the legacy booleans for now. The cutover to weight/slant and the underline/strike object forms lands in the next phase with the editor widgets that force it, so the representation and the controls that drive it move together.

face_specs.py holds the canonical defaults. In app-core.js, normalizePkgFace and packagesForExport carry and emit the new attrs: distant-fg resolves through the palette like fg/bg, and each attr exports only when set, so existing presets re-export unchanged. app.js syntaxBlank, uiFaceBlank, and seedFace match the shape.

Nothing changed shape, so dupre, distinguished, sterling, now, theme, and WIP all emit byte-identical themes. make check green: Python 58, Node 193, ERT 40.
---
 scripts/theme-studio/test-app-core.mjs | 57 ++++++++++++++++++++++++++++++----
 1 file changed, 51 insertions(+), 6 deletions(-)

(limited to 'scripts/theme-studio/test-app-core.mjs')

diff --git a/scripts/theme-studio/test-app-core.mjs b/scripts/theme-studio/test-app-core.mjs
index 8f62ae55a..f45a72be5 100644
--- a/scripts/theme-studio/test-app-core.mjs
+++ b/scripts/theme-studio/test-app-core.mjs
@@ -630,16 +630,38 @@ test('buildPkgmap: Normal — seeds faces, resolving names and applying defaults
 
 test('normalizePkgFace: Normal — fills every package face field', () => {
   assert.deepEqual(normalizePkgFace({ fg: 'blue', bold: true, inherit: 'base' }, 'default', PAL), {
-    fg: '#67809c', bg: null, bold: true, italic: false, underline: false,
-    strike: false, inherit: 'base', height: 1, box: null, source: 'default',
+    fg: '#67809c', bg: null, 'distant-fg': null, family: null, bold: true,
+    italic: false, underline: false, strike: false, overline: null,
+    inherit: 'base', height: 1, box: null, inverse: false, extend: false,
+    source: 'default',
   });
 });
 
+test('normalizePkgFace: Normal — carries the additive attribute model', () => {
+  const f = normalizePkgFace({
+    fg: 'blue', 'distant-fg': '#222222', family: 'Iosevka',
+    overline: { color: '#abcdef' }, inverse: true, extend: 1, height: 1.4,
+  }, 'user', PAL);
+  assert.equal(f['distant-fg'], '#222222');
+  assert.equal(f.family, 'Iosevka');
+  assert.deepEqual(f.overline, { color: '#abcdef' });
+  assert.equal(f.inverse, true);
+  assert.equal(f.extend, true); // coerced to boolean
+  assert.equal(f.height, 1.4);
+});
+
+test('normalizePkgFace: Boundary — distant-fg resolves through the palette', () => {
+  const f = normalizePkgFace({ 'distant-fg': 'blue' }, 'user', PAL);
+  assert.equal(f['distant-fg'], '#67809c');
+});
+
 test('buildPkgmap: Boundary — a face with no default dict still seeds blank', () => {
   const m = buildPkgmap({ a: { faces: [['f', 'f']] } }, PAL);
   assert.deepEqual(m.a.f, {
-    fg: null, bg: null, bold: false, italic: false, underline: false,
-    strike: false, inherit: null, height: 1, box: null, source: 'default',
+    fg: null, bg: null, 'distant-fg': null, family: null, bold: false,
+    italic: false, underline: false, strike: false, overline: null,
+    inherit: null, height: 1, box: null, inverse: false, extend: false,
+    source: 'default',
   });
 });
 
@@ -689,12 +711,35 @@ test('packagesForExport: Error — faces with an unknown source are skipped', ()
   assert.deepEqual(packagesForExport(m), {});
 });
 
+test('packagesForExport: Normal — emits additive attrs only when set', () => {
+  const m = { a: { f: normalizePkgFace({
+    fg: '#67809c', 'distant-fg': '#222222', family: 'Iosevka',
+    overline: { color: '#abcdef' }, inverse: true, extend: true,
+  }, 'user') } };
+  const o = packagesForExport(m).a.f;
+  assert.equal(o['distant-fg'], '#222222');
+  assert.equal(o.family, 'Iosevka');
+  assert.deepEqual(o.overline, { color: '#abcdef' });
+  assert.equal(o.inverse, true);
+  assert.equal(o.extend, true);
+});
+
+test('packagesForExport: Boundary — unset additive attrs are omitted', () => {
+  const m = { a: { f: normalizePkgFace({ fg: '#67809c' }, 'user') } };
+  const o = packagesForExport(m).a.f;
+  for (const k of ['distant-fg', 'family', 'overline', 'inverse', 'extend']) {
+    assert.ok(!(k in o), k + ' is omitted when unset');
+  }
+});
+
 test('mergePackagesInto: Normal — fills missing fields with defaults', () => {
   const m = {};
   mergePackagesInto(m, { a: { f: { fg: '#112233' } } });
   assert.deepEqual(m.a.f, {
-    fg: '#112233', bg: null, bold: false, italic: false, underline: false,
-    strike: false, inherit: null, height: 1, box: null, source: 'user',
+    fg: '#112233', bg: null, 'distant-fg': null, family: null, bold: false,
+    italic: false, underline: false, strike: false, overline: null,
+    inherit: null, height: 1, box: null, inverse: false, extend: false,
+    source: 'user',
   });
 });
 
-- 
cgit v1.2.3