From d84aa4374af5e3447445377a836c66cc07d7a223 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Sat, 16 May 2026 03:55:49 -0500
Subject: refactor(prog): six programming-track hygiene fixes from re-review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- prog-lsp.el: rename `cj/lsp--remove-eldoc-provider' →
  `cj/lsp--remove-eldoc-provider-global' and call it once from the
  lsp-mode `:config' block instead of attaching it per-buffer via
  `lsp-managed-mode-hook'.  The previous per-buffer remove with the
  buffer-local flag raced lsp-mode's own population of the local
  hook; removing the provider from the global default before any LSP
  buffer attaches makes the absence stick.  Two existing tests
  updated to the new contract (remove-from-default + idempotent
  re-run).

- prog-webdev.el / prog-python.el: warn at load time when
  `prettier' or `pyright' is missing on PATH via
  `cj/executable-find-or-warn'.  Both modules now `(require
  'system-lib)' to expose the helper.  Missing dependencies surface
  up front instead of mid-edit at first format/LSP attach.

- keyboard-compat.el: document existing idempotence.  The hook
  install uses a named function so `add-hook' deduplicates, and the
  hook body only calls `define-key' (latest binding wins, same
  value) -- adding a comment so future readers don't re-question.

- dev-fkeys.el: add a `typescript' clause to
  `cj/--f6-test-runner-cmd-for'.  F6 now runs `npx --no-install
  vitest <path>' when vitest is on PATH, otherwise `npx --no-install
  jest <path>'.  Updates the matching test from "returns nil" to
  cover both code paths; the impl-level test now asserts the routed
  command instead of expecting a user-error.

- flycheck-config.el: build the LanguageTool wrapper path with
  `(expand-file-name "scripts/languagetool-flycheck"
  user-emacs-directory)' instead of a hardcoded `~/.emacs.d/...'.
  Survives a non-standard `user-emacs-directory'.

- latex-config.el: replace the hardcoded Zathura viewer with
  `cj/--latex-select-pdf-viewer', which walks
  `cj/--latex-pdf-viewer-candidates' (zathura → evince → okular →
  SumatraPDF → xdg-open) and falls back to "PDF Tools" when nothing
  is on PATH.  Each entry maps an executable to the matching
  TeX-view-program-list name so AUCTeX's defaults handle the
  actual viewer invocation.
---
 tests/test-dev-fkeys--f6-current-file-tests-impl.el | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

(limited to 'tests/test-dev-fkeys--f6-current-file-tests-impl.el')

diff --git a/tests/test-dev-fkeys--f6-current-file-tests-impl.el b/tests/test-dev-fkeys--f6-current-file-tests-impl.el
index 318a78dba..1cf222305 100644
--- a/tests/test-dev-fkeys--f6-current-file-tests-impl.el
+++ b/tests/test-dev-fkeys--f6-current-file-tests-impl.el
@@ -105,13 +105,17 @@ just that file's tests run, not the whole module's prefix."
                    "/home/u/proj/modules/foo.el" nil)
                   :type 'user-error)))
 
-(ert-deftest test-dev-fkeys-f6-current-file-tests-impl-unsupported-language-errors ()
-  "Error: a file with no language-specific runner signals a user-error
-naming the language."
-  (cl-letf (((symbol-function 'compile) (lambda (_cmd) nil)))
-    (should-error (cj/--f6-current-file-tests-impl
-                   "/home/u/proj/src/foo.test.ts" "/home/u/proj/")
-                  :type 'user-error)))
+(ert-deftest test-dev-fkeys-f6-current-file-tests-impl-typescript-runs-jest ()
+  "TypeScript now routes to the `npx --no-install jest|vitest <path>'
+runner instead of erroring as unsupported."
+  (let ((compile-called nil))
+    (cl-letf (((symbol-function 'compile)
+               (lambda (cmd) (setq compile-called cmd)))
+              ((symbol-function 'executable-find) (lambda (_) nil)))
+      (cj/--f6-current-file-tests-impl
+       "/home/u/proj/src/foo.test.ts" "/home/u/proj/")
+      (should (stringp compile-called))
+      (should (string-match-p "jest src/foo.test.ts" compile-called)))))
 
 (ert-deftest test-dev-fkeys-f6-current-file-tests-impl-unknown-language-errors ()
   "Error: an unknown extension signals a user-error rather than running
-- 
cgit v1.2.3