From c4cf8d7d87e3d4f1adf74d89e372e16dbf0411fb Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sat, 16 May 2026 03:55:49 -0500 Subject: refactor(prog): six programming-track hygiene fixes from re-review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - prog-lsp.el: rename `cj/lsp--remove-eldoc-provider' → `cj/lsp--remove-eldoc-provider-global' and call it once from the lsp-mode `:config' block instead of attaching it per-buffer via `lsp-managed-mode-hook'. The previous per-buffer remove with the buffer-local flag raced lsp-mode's own population of the local hook; removing the provider from the global default before any LSP buffer attaches makes the absence stick. Two existing tests updated to the new contract (remove-from-default + idempotent re-run). - prog-webdev.el / prog-python.el: warn at load time when `prettier' or `pyright' is missing on PATH via `cj/executable-find-or-warn'. Both modules now `(require 'system-lib)' to expose the helper. Missing dependencies surface up front instead of mid-edit at first format/LSP attach. - keyboard-compat.el: document existing idempotence. The hook install uses a named function so `add-hook' deduplicates, and the hook body only calls `define-key' (latest binding wins, same value) -- adding a comment so future readers don't re-question. - dev-fkeys.el: add a `typescript' clause to `cj/--f6-test-runner-cmd-for'. F6 now runs `npx --no-install vitest ' when vitest is on PATH, otherwise `npx --no-install jest '. Updates the matching test from "returns nil" to cover both code paths; the impl-level test now asserts the routed command instead of expecting a user-error. - flycheck-config.el: build the LanguageTool wrapper path with `(expand-file-name "scripts/languagetool-flycheck" user-emacs-directory)' instead of a hardcoded `~/.emacs.d/...'. Survives a non-standard `user-emacs-directory'. - latex-config.el: replace the hardcoded Zathura viewer with `cj/--latex-select-pdf-viewer', which walks `cj/--latex-pdf-viewer-candidates' (zathura → evince → okular → SumatraPDF → xdg-open) and falls back to "PDF Tools" when nothing is on PATH. Each entry maps an executable to the matching TeX-view-program-list name so AUCTeX's defaults handle the actual viewer invocation. --- tests/test-dev-fkeys--f6-test-runner-cmd-for.el | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) (limited to 'tests/test-dev-fkeys--f6-test-runner-cmd-for.el') diff --git a/tests/test-dev-fkeys--f6-test-runner-cmd-for.el b/tests/test-dev-fkeys--f6-test-runner-cmd-for.el index 36f97548..9a552612 100644 --- a/tests/test-dev-fkeys--f6-test-runner-cmd-for.el +++ b/tests/test-dev-fkeys--f6-test-runner-cmd-for.el @@ -118,10 +118,25 @@ would over-match. Pass just the basename — the Makefile re-prepends ;;; Error Cases -(ert-deftest test-dev-fkeys-f6-cmd-for-typescript-returns-nil () - "Error: TypeScript is punted for v1 and returns nil." - (should (null (cj/--f6-test-runner-cmd-for - 'typescript t "src/foo.test.ts" "foo" "src")))) +(ert-deftest test-dev-fkeys-f6-cmd-for-typescript-uses-jest-or-vitest () + "Normal: TypeScript builds an `npx vitest|jest ' command. +Picks vitest when on PATH, jest otherwise. Falls back to jest as the +default runner so the command shape is always inspectable -- even if +neither tool is present, the user gets a clear runner-not-found error +rather than a silent nil that F6's outer wrapper interprets as +\"language unsupported.\"" + (cl-letf (((symbol-function 'executable-find) + (lambda (_) nil))) + (should (equal + (cj/--f6-test-runner-cmd-for + 'typescript t "src/foo.test.ts" "foo" "src") + "npx --no-install jest src/foo.test.ts"))) + (cl-letf (((symbol-function 'executable-find) + (lambda (p) (when (equal p "vitest") "/usr/bin/vitest")))) + (should (equal + (cj/--f6-test-runner-cmd-for + 'typescript t "src/foo.test.ts" "foo" "src") + "npx --no-install vitest src/foo.test.ts")))) (ert-deftest test-dev-fkeys-f6-cmd-for-javascript-returns-nil () "Error: JavaScript is punted for v1 and returns nil." -- cgit v1.2.3