From c3720afd638270dc3fcc2b6ee4f7d26bdde634e8 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Sat, 18 Jul 2026 17:28:58 -0500
Subject: refactor: launch external processes with argv lists, not shells

- open-this-file-with splits the typed command and calls call-process.
- media-play-it resolves streams via a yt-dlp capture, then start-process.
- Paths, URLs, and player args never meet a shell.
- yt-dlp stderr is captured separately so warnings can't parse as URLs.
- Stream resolution now blocks briefly. mpv (the default) is unaffected.
---
 tests/test-external-open-commands.el | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

(limited to 'tests/test-external-open-commands.el')

diff --git a/tests/test-external-open-commands.el b/tests/test-external-open-commands.el
index 3d8adc15..3b2d32b8 100644
--- a/tests/test-external-open-commands.el
+++ b/tests/test-external-open-commands.el
@@ -64,19 +64,28 @@
     (should-error (cj/open-this-file-with "vlc") :type 'user-error)))
 
 (ert-deftest test-external-open-open-this-file-with-spawns-detached-process ()
-  "Normal: posix path invokes `call-process-shell-command' with nohup + bg."
-  (let ((cmd nil))
+  "Normal: posix path launches an argv `call-process' with DESTINATION 0."
+  (let ((captured nil))
     (with-temp-buffer
-      (setq buffer-file-name "/tmp/foo.mp4")
+      (setq buffer-file-name "/tmp/my file.mp4")
       (cl-letf (((symbol-function 'env-windows-p) (lambda () nil))
-                ((symbol-function 'call-process-shell-command)
-                 (lambda (c _infile _buf &rest _)
-                   (setq cmd c))))
-        (cj/open-this-file-with "vlc"))
+                ((symbol-function 'executable-find)
+                 (lambda (&rest _) "/usr/bin/vlc"))
+                ((symbol-function 'call-process)
+                 (lambda (&rest args) (setq captured args) 0)))
+        (cj/open-this-file-with "vlc --fs"))
       (setq buffer-file-name nil))
-    (should (string-match-p "^nohup vlc " cmd))
-    (should (string-match-p "&$" cmd))
-    (should (string-match-p ">/dev/null" cmd))))
+    (should (equal captured '("vlc" nil 0 nil "--fs" "/tmp/my file.mp4")))))
+
+(ert-deftest test-external-open-open-this-file-with-errors-missing-program ()
+  "Error: a program not on PATH signals user-error before launching."
+  (with-temp-buffer
+    (setq buffer-file-name "/tmp/foo.mp4")
+    (cl-letf (((symbol-function 'env-windows-p) (lambda () nil))
+              ((symbol-function 'executable-find) (lambda (&rest _) nil)))
+      (should-error (cj/open-this-file-with "no-such-program")
+                    :type 'user-error))
+    (setq buffer-file-name nil)))
 
 ;;; cj/find-file-auto
 
-- 
cgit v1.2.3