From f30a96edd320337ea9a35d2f0fc0cf21f94deb05 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Thu, 16 Jul 2026 15:59:50 -0500 Subject: fix(test): stop silently skipping every integration test INTEGRATION_TESTS globbed test-integration-%.el through $(wildcard ...), which takes a shell glob where % is a literal character, not a pattern. It expanded to nothing, so test-all skipped the integration phase and still printed "All tests complete". Fourteen files never ran, for as long as the variable has existed. The % is right one line up, because filter-out does take make patterns. The glob is now test-integration-*.el, and the counts add up: 597 unit + 14 integration = the 611 test files on disk. Turning the gate on surfaced five failures, none of them in production code. Four were rotting fixtures. parse-ics drops events outside a rolling window of today minus calendar-sync-past-months to plus future-months, and four tests fed it dates pinned to November 2025 or February 2026. They passed when written and began failing once the window slid past them. Their neighbours survived for two reasons: some hand their fixture to parse-event, which applies no window, and the weekly ones use unbounded RRULEs that keep generating into the window however old the DTSTART is. The fixtures now build dates relative to now, which is what the timezone file's own helper already did. The fifth was a real regression, caught five months late. The recording toggle test asserted on a fixture device and got whatever hardware is plugged into the developer's machine. cj/recording-get-devices runs --validate-system-audio, which shells to pactl, finds the fixture device isn't a real source, and auto-fixes the configured device to the default sink's monitor. The test mocked start-process-shell-command but not shell-command-to-string, so validation reached the real machine. It passes at 5bdd3420~1 and fails at 5bdd3420, the commit that added that validation in February. I faked pactl at the shell boundary rather than stubbing --validate-system-audio out, so the validation logic still runs, against a fixture machine. --- tests/test-integration-calendar-sync-timezone.el | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) (limited to 'tests/test-integration-calendar-sync-timezone.el') diff --git a/tests/test-integration-calendar-sync-timezone.el b/tests/test-integration-calendar-sync-timezone.el index 304d3233..a3f65146 100644 --- a/tests/test-integration-calendar-sync-timezone.el +++ b/tests/test-integration-calendar-sync-timezone.el @@ -187,12 +187,21 @@ Components integrated: Validates: - Org timestamp format is correct () -- Hour in timestamp is the converted local hour" - (let* ((source-time (list 2026 2 2 19 0)) +- Hour in timestamp is the converted local hour + +The date is generated relative to now because `calendar-sync--parse-ics' +drops events outside `calendar-sync--get-date-range' (today minus +`calendar-sync-past-months', plus `calendar-sync-future-months'). This test +used a hardcoded 2026-02-02, which sat inside that window when it was written +and fell out of it once three months had passed -- the event was filtered +before rendering and the assertion failed against an empty org buffer. The +sibling tests survived hardcoded dates only because they call +`calendar-sync--parse-event' directly, which applies no range filter." + (let* ((source-time (test-calendar-sync-time-days-from-now 7 19 0)) (ics (test-integration-tz--make-ics-with-tzid-event "Test Event" source-time "Europe/Lisbon")) - (expected-local (test-calendar-sync-convert-tz-via-date - 2026 2 2 19 0 "Europe/Lisbon")) + (expected-local (apply #'test-calendar-sync-convert-tz-via-date + (append source-time (list "Europe/Lisbon")))) (expected-hour (nth 3 expected-local)) (org-output (calendar-sync--parse-ics ics))) (should org-output) -- cgit v1.2.3