From 18ba99fda928769adb235bd85b485c8be94c3ddd Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 12 May 2026 00:45:36 -0500 Subject: fix(mail): clear the marks after saving from the attachment selector `cj/mu4e-attachment-selection-save-marked' left the `[x]' marks set after a successful save, so a second `s' silently re-saved the same files. It now unmarks every row and re-renders once the save returns, so the buffer stays open for another batch (and `q'/RET still exit). The save-marked test asserts the marks are cleared. --- tests/test-mu4e-attachments.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/test-mu4e-attachments.el b/tests/test-mu4e-attachments.el index 3105d710..21336f75 100644 --- a/tests/test-mu4e-attachments.el +++ b/tests/test-mu4e-attachments.el @@ -192,7 +192,11 @@ so this fails the same way whether or not mu4e's MIME support is loadable." ((symbol-function 'message) (lambda (&rest _) nil))) (should (equal (cj/mu4e-attachment-selection-save-marked) '("/downloads/b.pdf"))) - (should (equal saved (list (list b) "/downloads/"))))) + (should (equal saved (list (list b) "/downloads/"))) + ;; marks clear after a successful save so `s' won't re-save them + (should-not (seq-some (lambda (entry) (plist-get entry :selected)) + cj/mu4e-attachment-selection-entries)) + (should (string-match-p "\\[ \\] b\\.pdf" (buffer-string))))) (kill-buffer buffer)))) (ert-deftest test-mu4e-attachments-selection-save-marked-errors-when-empty () -- cgit v1.2.3