From 8cb30ef6efd06464ab1153b99261a3f626149f97 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 12 May 2026 00:42:52 -0500 Subject: fix(slack): error when adding a reaction outside a Slack buffer `cj/slack-message-add-reaction' wrapped its whole body in `when-let*' on `slack-current-buffer', so invoking C-; S ! outside a Slack message view did nothing at all, and with no message it looked like the key wasn't even bound. It now `user-error's "Not in a Slack buffer". A test covers the case. --- tests/test-slack-config-reactions.el | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'tests') diff --git a/tests/test-slack-config-reactions.el b/tests/test-slack-config-reactions.el index a5755a49..491b8147 100644 --- a/tests/test-slack-config-reactions.el +++ b/tests/test-slack-config-reactions.el @@ -87,5 +87,10 @@ (cj/slack-message-add-reaction) (should (equal called '(:buffer "pray" "123.456")))))) +(ert-deftest test-slack-config-message-add-reaction-errors-outside-slack-buffer () + "Error: invoking the reaction command outside a Slack buffer fails clearly." + (let ((slack-current-buffer nil)) + (should-error (cj/slack-message-add-reaction) :type 'user-error))) + (provide 'test-slack-config-reactions) ;;; test-slack-config-reactions.el ends here -- cgit v1.2.3