From 937be691cd921eeaebac0349782d985edba820cd Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Mon, 25 May 2026 18:29:31 -0500 Subject: refactor(eshell): move SSH-jump hosts into a defcustom MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The eshell SSH-jump aliases (gocj, gosb, gowolf) were hardcoded inline in the alias setup, which tied the module to my machines. I moved them into a cj/eshell-ssh-hosts defcustom (an alias→remote-path alist, defaulting to my current hosts) and build the aliases by iterating it. A different machine can override the variable or set it to nil instead of editing the module. Extracted a pure cj/--eshell-ssh-alias-commands helper so the alias construction is testable without a live eshell. --- tests/test-eshell-config-ssh-aliases.el | 50 +++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 tests/test-eshell-config-ssh-aliases.el (limited to 'tests') diff --git a/tests/test-eshell-config-ssh-aliases.el b/tests/test-eshell-config-ssh-aliases.el new file mode 100644 index 00000000..8d30801f --- /dev/null +++ b/tests/test-eshell-config-ssh-aliases.el @@ -0,0 +1,50 @@ +;;; test-eshell-config-ssh-aliases.el --- Tests for eshell SSH alias building -*- lexical-binding: t; -*- + +;;; Commentary: +;; Tests for cj/--eshell-ssh-alias-commands from eshell-config.el. +;; +;; The helper takes the `cj/eshell-ssh-hosts' alist of (ALIAS-NAME . REMOTE-PATH) +;; and returns (ALIAS-NAME . COMMAND) pairs where COMMAND is the `cd' string +;; `eshell/alias' runs. Testing the pure helper avoids needing a live Eshell. + +;;; Code: + +(require 'ert) +(require 'cl-lib) +(require 'package) + +(setq package-user-dir (expand-file-name "elpa" user-emacs-directory)) +(package-initialize) +(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory)) +(require 'eshell-config) + +(declare-function cj/--eshell-ssh-alias-commands "eshell-config" (hosts)) + +;;; Normal Cases + +(ert-deftest test-eshell-config-ssh-alias-commands-normal-two-hosts () + "Normal: two hosts produce two cd-command alias pairs." + (let* ((hosts '(("gosb" . "/sshx:cjennings@wolf.usbx.me:/home/cjennings/") + ("gowolf" . "/sshx:cjennings@wolf.usbx.me:/home/cjennings/"))) + (result (cj/--eshell-ssh-alias-commands hosts))) + (should (= 2 (length result))) + (should (equal (assoc "gosb" result) + '("gosb" . "cd /sshx:cjennings@wolf.usbx.me:/home/cjennings/"))) + (should (equal (assoc "gowolf" result) + '("gowolf" . "cd /sshx:cjennings@wolf.usbx.me:/home/cjennings/"))))) + +(ert-deftest test-eshell-config-ssh-alias-commands-normal-single-host () + "Normal: a single host produces one pair, order preserved." + (let ((result (cj/--eshell-ssh-alias-commands + '(("gocj" . "/sshx:cjennings@cjennings.net:/var/cjennings/"))))) + (should (equal result + '(("gocj" . "cd /sshx:cjennings@cjennings.net:/var/cjennings/")))))) + +;;; Boundary Cases + +(ert-deftest test-eshell-config-ssh-alias-commands-boundary-empty () + "Boundary: an empty host list produces no SSH aliases." + (should (null (cj/--eshell-ssh-alias-commands '())))) + +(provide 'test-eshell-config-ssh-aliases) +;;; test-eshell-config-ssh-aliases.el ends here. -- cgit v1.2.3