From a09398f27f1e93bfbe84e1dd185e70b391e82888 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Mon, 25 May 2026 19:11:00 -0500 Subject: feat(user-constants): make required-path init failures actionable cj/verify-or-create-dir and cj/verify-or-create-file caught every creation failure and only messaged it, so a broken environment for a path the config actually needs stayed quiet until some later module failed in a more confusing way. I gave both an optional required flag and routed failures through a shared cj/--report-path-failure: a required failure raises a prominent display-warning, an optional one is still just logged so it never blocks startup. The initializer now groups its paths by that distinction. Required: the backbone directories (sync, org, roam) and the calendar stubs (gcal/pcal/dcal), since org-agenda-list hangs prompting for those when they're missing. Optional: the secondary dirs and the content files, each populated by its own workflow. I went with a warning rather than a user-error for required failures so a directory hiccup surfaces loudly without aborting init. Added error-path tests: an optional failure logs and never warns, and a required dir or file failure raises a user-constants warning. --- tests/test-user-constants.el | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) (limited to 'tests') diff --git a/tests/test-user-constants.el b/tests/test-user-constants.el index 5246e7ea..8dd9284f 100644 --- a/tests/test-user-constants.el +++ b/tests/test-user-constants.el @@ -77,5 +77,48 @@ The whole point of the split — a bare require must not touch the filesystem." (should (file-exists-p schedule-file)) (should (file-exists-p inbox-file)))) +;;; verify-or-create failure reporting (required vs optional) + +;; A path under a nonexistent root makes file-directory-p / file-exists-p return +;; nil naturally, so the only stub needed is make-directory failing — no need to +;; redefine core predicates (which trips native-comp trampolines). + +(ert-deftest test-user-constants-verify-dir-optional-failure-logs () + "Error: an optional directory failure is logged, never warned or signalled." + (test-user-constants--load) + (let ((warned nil) (messaged nil)) + (cl-letf (((symbol-function 'make-directory) (lambda (&rest _) (error "boom"))) + ((symbol-function 'display-warning) (lambda (&rest _) (setq warned t))) + ((symbol-function 'message) (lambda (&rest _) (setq messaged t)))) + (cj/verify-or-create-dir "/nonexistent-uc-test/optional") + (should messaged) + (should-not warned)))) + +(ert-deftest test-user-constants-verify-dir-required-failure-warns () + "Error: a required directory failure raises a prominent user-constants warning." + (test-user-constants--load) + (let ((warn-args nil)) + (cl-letf (((symbol-function 'make-directory) (lambda (&rest _) (error "boom"))) + ((symbol-function 'display-warning) + (lambda (group _msg &optional level) (setq warn-args (list group level))))) + (cj/verify-or-create-dir "/nonexistent-uc-test/required" t) + (should (eq (nth 0 warn-args) 'user-constants)) + (should (eq (nth 1 warn-args) :error))))) + +(ert-deftest test-user-constants-verify-file-required-failure-warns () + "Error: a required file failure raises a prominent user-constants warning." + (test-user-constants--load) + (let ((dir (make-temp-file "uc-reqfile-" t)) + (warn-args nil)) + (unwind-protect + (cl-letf (((symbol-function 'write-region) (lambda (&rest _) (error "boom"))) + ((symbol-function 'display-warning) + (lambda (group _msg &optional level) (setq warn-args (list group level))))) + ;; dir exists so the failure is the write, not the parent directory + (cj/verify-or-create-file (expand-file-name "required.org" dir) t) + (should (eq (nth 0 warn-args) 'user-constants)) + (should (eq (nth 1 warn-args) :error))) + (delete-directory dir t)))) + (provide 'test-user-constants) ;;; test-user-constants.el ends here -- cgit v1.2.3