From ed7e6b2a89fc31d2e23f2c53f8af49d3ff00586d Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Sat, 20 Jun 2026 11:25:36 -0400
Subject: refactor: remove dead wrappers and commented-out blocks

Drop cj/apply-browser-choice (browser-config) and cj/load-fallback-theme (ui-theme), orphaned wrappers with no caller that just duplicated logic the live paths already inline, plus their tests. Delete commented-out blocks: a duplicate contact capture template (org-contacts-config), a disabled personal-info-dir :init (help-config), a stale TODO setq (org-config), and an old commented regex (test-runner).
---
 tests/test-browser-config.el    | 23 -----------------------
 tests/test-ui-theme-commands.el | 18 ------------------
 2 files changed, 41 deletions(-)

(limited to 'tests')

diff --git a/tests/test-browser-config.el b/tests/test-browser-config.el
index 7faecbfc8..9fe5b02e4 100644
--- a/tests/test-browser-config.el
+++ b/tests/test-browser-config.el
@@ -273,29 +273,6 @@
       (should (string= (plist-get loaded :name) "Second"))))
   (test-browser-teardown))
 
-;;; Public wrappers (message side-effects mocked)
-
-(ert-deftest test-browser-apply-wrapper-success-messages-name ()
-  "Normal: =cj/apply-browser-choice= reports the chosen name on success."
-  (test-browser-setup)
-  (let ((browser (test-browser-make-plist "Wrapper Test"))
-        (received nil))
-    (cl-letf (((symbol-function 'message)
-               (lambda (fmt &rest args) (setq received (apply #'format fmt args)))))
-      (cj/apply-browser-choice browser))
-    (should (string-match-p "Wrapper Test" received))
-    (should (string-match-p "Default browser set" received)))
-  (test-browser-teardown))
-
-(ert-deftest test-browser-apply-wrapper-invalid-plist-messages-error ()
-  "Error: =cj/apply-browser-choice= surfaces an error message for a bad plist."
-  (test-browser-setup)
-  (let ((received nil))
-    (cl-letf (((symbol-function 'message)
-               (lambda (fmt &rest args) (setq received (apply #'format fmt args)))))
-      (cj/apply-browser-choice nil))
-    (should (string-match-p "Invalid" received)))
-  (test-browser-teardown))
 
 (ert-deftest test-browser-initialize-wrapper-loaded-branch-applies ()
   "Normal: =cj/initialize-browser= applies the saved browser when one is loaded."
diff --git a/tests/test-ui-theme-commands.el b/tests/test-ui-theme-commands.el
index 4e3ce7f28..1b273cf57 100644
--- a/tests/test-ui-theme-commands.el
+++ b/tests/test-ui-theme-commands.el
@@ -7,7 +7,6 @@
 ;;   cj/switch-themes
 ;;   cj/save-theme-to-file
 ;;   cj/get-active-theme-name
-;;   cj/load-fallback-theme
 
 ;;; Code:
 
@@ -68,23 +67,6 @@ does not raise."
       (cj/save-theme-to-file))
     (should (string-match-p "Cannot save theme" messaged))))
 
-;;; cj/load-fallback-theme
-
-(ert-deftest test-ui-theme-load-fallback-disables-then-loads ()
-  "Normal: load-fallback-theme disables all then loads the fallback."
-  (let ((fallback-theme-name "modus-vivendi")
-        (custom-enabled-themes '(old-one old-two))
-        disabled loaded)
-    (cl-letf (((symbol-function 'disable-theme)
-               (lambda (theme) (push theme disabled)))
-              ((symbol-function 'load-theme)
-               (lambda (theme &optional _no-confirm _no-enable)
-                 (push theme loaded)))
-              ((symbol-function 'message) #'ignore))
-      (cj/load-fallback-theme "boom"))
-    (should (equal (sort (copy-sequence disabled) #'string<) '(old-one old-two)))
-    (should (equal loaded '(modus-vivendi)))))
-
 ;;; cj/switch-themes
 
 (ert-deftest test-ui-theme-switch-disables-loads-then-saves ()
-- 
cgit v1.2.3