From 871bb3ab771b6235cbbeb4e4122e65c601c182b1 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sun, 7 Jun 2026 08:30:31 -0500 Subject: fix(dupre): make diff-changed and diff-refine-changed legible diff-refine-changed rendered the default foreground (#f0fef0) on the bright-gold yellow-1 (#ffd700) at WCAG contrast 1.35, unreadable wherever the face is a plain background, not inside diff-mode's own foreground overlay. diff-changed was weak too at 2.78. Both now use the default foreground on the dark amber yellow-2 (#875f00), already in dupre's palette, for a contrast of 5.49. diff-refine-changed keeps its bold weight so it stays stronger than diff-changed. A WCAG-contrast test guards both faces from dropping below 4.5. --- themes/dupre-faces.el | 4 ++-- themes/dupre-palette.el | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'themes') diff --git a/themes/dupre-faces.el b/themes/dupre-faces.el index 8fad4c626..17daa41c1 100644 --- a/themes/dupre-faces.el +++ b/themes/dupre-faces.el @@ -164,10 +164,10 @@ ;;;;; Diff mode `(diff-added ((t (:foreground ,green :background ,green-2)))) `(diff-removed ((t (:foreground ,red :background ,red-3)))) - `(diff-changed ((t (:foreground ,yellow :background ,yellow-2)))) + `(diff-changed ((t (:foreground ,fg :background ,yellow-2)))) `(diff-refine-added ((t (:foreground ,fg :background ,green-1 :weight bold)))) `(diff-refine-removed ((t (:foreground ,fg :background ,red-2 :weight bold)))) - `(diff-refine-changed ((t (:foreground ,fg :background ,yellow-1 :weight bold)))) + `(diff-refine-changed ((t (:foreground ,fg :background ,yellow-2 :weight bold)))) `(diff-header ((t (:foreground ,fg :background ,bg+2)))) `(diff-file-header ((t (:foreground ,blue :background ,bg+2 :weight bold)))) `(diff-hunk-header ((t (:foreground ,gray+1 :background ,bg+1)))) diff --git a/themes/dupre-palette.el b/themes/dupre-palette.el index 3901ef82b..d6715a788 100644 --- a/themes/dupre-palette.el +++ b/themes/dupre-palette.el @@ -95,7 +95,7 @@ Each entry is (NAME VALUE) where VALUE is a hex color string.") (diff-removed-bg red-3) (diff-removed-fg red) (diff-changed-bg yellow-2) - (diff-changed-fg yellow)) + (diff-changed-fg fg)) "Semantic color mappings for dupre-theme. Each entry maps a semantic name to a palette color name.") -- cgit v1.2.3