From 18a1b4294a857a0e975a1aa4f11d1824ccdcc121 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sun, 28 Jun 2026 06:54:37 -0400 Subject: chore(todo): close the wttrin theme-studio task Recorded wttrin's inventory capture, the two non-blocking residuals (a full clean-daemon regen for the other local checkouts, and the eval-defined wttrin-instructions-header), and filed the studio visual confirm. --- todo.org | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'todo.org') diff --git a/todo.org b/todo.org index 5cfb69ef7..402f60968 100644 --- a/todo.org +++ b/todo.org @@ -83,6 +83,11 @@ What we're verifying: =C-; a n= (or =M-SPC=) cycles into a detached ai-term (ali - Confirm one is attached (a live =agent [...]= buffer) and one is detached (its =aiv-= tmux session is alive but has no buffer). - Press =C-; a n= repeatedly to cycle through the agents. Expected: the rotation includes the detached agent; landing on it recreates its terminal buffer and reattaches the tmux session (its live output appears), instead of skipping it. Order is stable (by buffer name) and wraps after the last. +*** VERIFY wttrin appears as a themeable app in theme-studio +What we're verifying: wttrin's four faces (=wttrin-instructions=, =wttrin-key=, =wttrin-mode-line-stale=, =wttrin-staleness-header=) now show up in the studio's package dropdown and render in a generic preview, after being added to =package-inventory.json= and the studio regenerated. Inventory + regen are verified mechanically (40 packages, all studio gates green); this is the visual confirm. +- Open the studio: =make -C scripts/theme-studio open= (or open =scripts/theme-studio/theme-studio.html= in Chrome). +- In the application/package dropdown, pick =wttrin=. +Expected: wttrin is listed, and its four faces are shown as editable rows in a generic preview. (If you later want the other local-checkout packages captured too, restart Emacs and re-run the inventory regen against the clean daemon.) *** VERIFY EAT diff backgrounds read dark enough (Claude Code diffs) What we're verifying: the added/removed line backgrounds in Claude Code diffs (=eat-term-color-22= / =-52=) now render at about half their former brightness (=#002f00= / =#2f0000=, down from =#005F00= / =#5F0000=) and read as comfortably dark while still clearly green/red. Themed via WIP.json + regenerated WIP-theme.el; live in the daemon. This is the darkness judgment only Craig can make. - In a live agent (EAT) buffer, have Claude show a colored diff with both added and removed lines (e.g. ask it to edit a file). @@ -440,11 +445,9 @@ What we're verifying: in dirvish, d now duplicates the file at point (delete-to- Expected: d duplicates; D names the exact targets and only deletes on yes; the files are gone with no trash copy. If sudo needs a password that shell-command can't supply, flag it — the delete may need to route through a tty instead. ** PROJECT [#A] Theme-Studio Open Work Parent grouping the open theme-studio / theming issues; close each child independently. -*** TODO [#C] wttrin preview in theme-studio :feature: -Root cause found, capture fixed (commit a5fd0b4d). The studio inventory (=build-inventory.el=) only captured faces defined in versioned dirs (=/elpa/PKG-VERSION/=); wttrin is an unversioned local checkout (=/elpa/wttrin/=) and was silently excluded. Not a branch dependency, despite my first read. The regex now matches unversioned checkouts too, verified on a clean wttrin load. Remaining: -1. Regenerate the inventory in a *clean* Emacs (restart first; the live daemon's wttrin face attribution got disturbed during the investigation). wttrin then becomes a generic-preview app with its four file-loaded faces, and the same regen picks up the other local-checkout packages the fix unblocked. -2. =wttrin-instructions-header= is eval-defined from outside this checkout (absent from =elpa/wttrin/wttrin.el=), so it is not captured until it lands in the checkout's compiled source. -3. Optional: a bespoke two-column-footer =renderWttrin= instead of the generic preview. +*** 2026-06-28 Sun @ 06:53:32 -0400 wttrin captured in the studio inventory (4 faces) +Root cause was the inventory regex (fixed in a5fd0b4d): it only captured =/elpa/PKG-VERSION/= dirs, excluding wttrin's unversioned =/elpa/wttrin/= checkout. Confirmed on a clean wttrin load that =symbol-file= attributes its faces to =/elpa/wttrin/wttrin.elc= correctly. The live daemon's wttrin attribution was disturbed by the session's theme reloading (=symbol-file= returns nil; reload + unload-feature didn't repair it), so I did NOT regenerate the whole inventory from the daemon (that would have lost attribution for other packages too). Instead, surgically added wttrin's four file-loaded faces (=wttrin-instructions=, =wttrin-key=, =wttrin-mode-line-stale=, =wttrin-staleness-header=) to =package-inventory.json= from a clean batch load, regenerated =theme-studio.html= (make gen), and confirmed all studio gates green. wttrin is now a generic-preview app in the dropdown. +Two residuals, neither blocking: (a) the OTHER local-checkout packages the regex fix unblocks are not yet captured — that needs one full inventory regen in a freshly-restarted (clean) daemon, best run after Craig's next Emacs restart; (b) =wttrin-instructions-header= is eval-defined outside the checkout (the checkout defines =wttrin-instructions=, not =-instructions-header=), so it can't be captured here — it would need to land in =elpa/wttrin/wttrin.el=. Optional polish: a bespoke two-column-footer =renderWttrin= instead of the generic preview. Visual confirm filed under "Manual testing and validation". *** 2026-06-27 Sat @ 22:05:31 -0400 Rebuilt the dirvish preview as a realistic two-pane Shipped in 61b68fcf (option 2). Two-pane dirvish: an active listing (per-type nerd-icons, sizes, hl-line, dimmed backup) beside an =ls -l= preview pane, the remaining faces in a labeled extras strip, all 38 dirvish faces still covered. Visual verified via off-screen screenshot. *** TODO [#A] theme-studio: consistent assignment-view table columns :feature:studio:next: -- cgit v1.2.3