From 2b7a3139e8f2aef5ca2e072a29e1892f517f77b7 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sat, 20 Jun 2026 15:30:06 -0400 Subject: chore(todo): file the F9 3-window-collapse bug and the f9-fix manual test --- todo.org | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) (limited to 'todo.org') diff --git a/todo.org b/todo.org index 1c31ded33..cc2ec432f 100644 --- a/todo.org +++ b/todo.org @@ -55,6 +55,21 @@ Tags are additive. For example, a small wrong-behavior fix can be =:bug:quick:=, and a feature that requires internal restructuring can be =:feature:refactor:=. * Emacs Open Work +** TODO [#B] F9 toggle collapses a 3-window layout to 2 :bug: +In a 3-window layout (e.g. code on top spanning full width, a main window, and the +agent as a full-width bottom strip), the first F9 toggle-off+on collapses three windows +to two — the top code window gets consumed — and the agent jumps to a larger height, +then stabilizes. Found 2026-06-20 while investigating the f9 split-shrink bug; reproduced +in batch (=/tmp/repro-f9b.el= scenario A: code|main|agent below, body-height 5 → 11, +windows 3 → 2 on the first toggle). + +Likely in the toggle-off teardown / display dispatch (=cj/--ai-term-toggle-off= deletes +the agent window; on toggle-on the chain reuse-existing-agent → reuse-edge-window → +display-saved picks a window/split that doesn't preserve the third window). The agent +display rule should restore into the agent's prior slot without eating an unrelated +window. Needs a characterization test that builds a 3-window layout, toggles, and asserts +the window count and the code window survive. GUI-verify after. + ** TODO [#B] Codebase refactoring program — remaining batch :refactor:solo: Resumes the full-codebase refactoring scan run of 2026-06-20 (8-agent fan-out over modules/ + scripts/theme-studio/). The goal: apply every scan finding except the @@ -460,6 +475,17 @@ What we're verifying: in dirvish, d now duplicates the file at point (delete-to- - Answer no first (confirm nothing happens), then press D again and answer yes - Note whether sudo prompts for a password and whether the file actually disappears Expected: d duplicates; D names the exact targets and only deletes on yes; the files are gone with no trash copy. If sudo needs a password that shell-command can't supply, flag it — the delete may need to route through a tty instead. +*** VERIFY F9 agent toggle no longer shrinks the window after a C-; b pull-away +What we're verifying: the f9 split-shrink bug is fixed. The toggle now captures the agent window's total-height (not body-height), so the capture/replay round-trip is immune to the mode line's pixel height — the agent should keep the same height across repeated toggles even with the WIP theme's near-zero =mode-line-inactive= (=:height 2=). The batch harness can't reproduce this (a TTY mode line is always a full line), so this needs a real GUI frame. +- Open the agent (F9) and maximize it so it fills the frame (=C-x 1= inside it) +- Pull it down with =C-; b = (the reveal slivers in above; the agent becomes the bottom window) and press == to end the sticky resize +- Note the agent window's height (eyeball it, or =M-:= the form below) +#+begin_src emacs-lisp +(window-total-height (get-buffer-window (current-buffer))) +#+end_src +- Press F9 to toggle the agent off, then F9 again to toggle it back on. Repeat 5–6 times. +- Re-check the height after each on-toggle +Expected: the agent window stays the same height every cycle (no one-line-per-toggle shrink). Before the fix it lost ~1 line each toggle. If it still shrinks, capture the height sequence and reopen this as a TODO — the remaining drift would point at a different rounding source than the mode-line pixel height. ** PROJECT [#A] Theme-Studio Open Work Parent grouping the open theme-studio / theming issues; close each child independently. -- cgit v1.2.3